-
Notifications
You must be signed in to change notification settings - Fork 14
fix: update black to fix ReDoS vulnerability #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Addresses Dependabot alert #65: - CVE-2024-21503: Regular Expression Denial of Service (ReDoS) vulnerability Added explicit black>=24.3.0 constraint to dev dependencies and updated uv.lock. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #582 +/- ##
=======================================
Coverage 76.01% 76.01%
=======================================
Files 42 42
Lines 2468 2468
=======================================
Hits 1876 1876
Misses 592 592
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
No idea if this is correct, feel free to resolve the security issue otherwise. |
Isn't this just a false positive, taking into account that this is a transitive dependency of Of course, it is completely wrong for |
|
Security issues in dev dependencies are also valid, because we use them in our CI where we have various secrets that could leak. But you are right that those issues are less important and often invalid for us. Still, if we can resolve them with a dependency bump, we should do so. What's the alternative here? I guess waiting for pydoc to update their dependencies? We can surely wait a bit with this, I was mostly testing how claude handles this kind of task, since it will get worse once we include more repositories in those checks. |
That makes sense, thanks.
The issue is that We can try to resolve this as proposed in the PR by explicitly constraining the |
Summary
blackto ≥24.3.0 to fix CVE-2024-21503 (Regular Expression Denial of Service)Test plan
uv lockcompletes successfully🤖 Generated with Claude Code