refactor!: polish logging across the codebase#1005
Open
vdusek wants to merge 1 commit into
Open
Conversation
Standardize internal modules on getLogger(__name__), rebalance log levels (no-op platform-only calls error->warning), and trim Scrapy trace-debug noise ahead of the next major release.
vdusek
added
adhoc
github-actions
Bot
added
the
tested
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1005 +/- ##
==========================================
- Coverage 91.61% 91.57% -0.04%
==========================================
Files 49 49
Lines 3171 3157 -14
==========================================
- Hits 2905 2891 -14
Misses 266 266
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Logging polish across the whole codebase:
Breaking changes
The typed public API is unchanged, but log output changes in a few minor ways:
error->warningfor the local no-opmetamorph()/reboot()/add_webhook()messages and the Scrapy scheduler skip.info->debugfor the "unknown platform event" message.apifytoapify.<module>for the charging, proxy, and events modules.