fix: Clamp negative timedelta in _get_remaining_time()#818
Merged
Conversation
When `timeout_at` is already in the past, the subtraction produces a negative timedelta that would be passed to API calls via `start`, `call`, or `call_task` with `timeout='inherit'`. Clamp to zero instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vdusek
added
adhoc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #818 +/- ##
==========================================
+ Coverage 85.88% 85.92% +0.03%
==========================================
Files 46 46
Lines 2778 2778
==========================================
+ Hits 2386 2387 +1
+ Misses 392 391 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
tested
Pijukatel
approved these changes
Mar 2, 2026
Contributor
Pijukatel
left a comment
Pijukatel
left a comment
There was a problem hiding this comment.
Was there some issue connected to this?
Contributor
Author
Not aware of that, I noticed this while working on something else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_get_remaining_time()could return a negativetimedeltaif the Actor's timeout had already passed. This clamps the result totimedelta(0)so callers never receive a negative remaining time.Test plan
timeout_atreturnstimedelta(0)instead of a negative valuetimeout_atreturns a positivetimedelta🤖 Generated with Claude Code