Rename config trait from SwiftConfiguration to Configuration#107
Merged
FranzBusch merged 2 commits intomainfrom Feb 19, 2026
Merged
Rename config trait from SwiftConfiguration to Configuration#107FranzBusch merged 2 commits intomainfrom
FranzBusch merged 2 commits intomainfrom
Conversation
FranzBusch
reviewed
Feb 18, 2026
Comment on lines
+28
to
+29
| .trait(name: "Configuration"), | ||
| .default(enabledTraits: ["Configuration"]), |
Member
There was a problem hiding this comment.
This trait should really not be here since it is just for vending the copied server.
Contributor
Author
There was a problem hiding this comment.
You think the trait should be removed? Could that be done separately from fixing the name?
aryan-25
added a commit
to swift-server/swift-http-server
that referenced
this pull request
Feb 19, 2026
Motivation: PR apple/swift-http-api-proposal#107 in `swift-http-api-proposal` renames the `"SwiftConfiguration"` trait name to `"Configuration"`, as the convention is to not use the "Swift" prefix in module/product/trait names. We should do the same in this repository. Modifications: Renamed the `"SwiftConfiguration"` trait to `"Configuration"`. Result: Trait name aligns with the standard convention.
FranzBusch
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We generally don't use the "Swift" prefix in module/product/trait names, so the trait name should be "Configuration", not "SwiftConfiguration".
That's what other important ecosystem packages have done as well, so let's follow their lead.
Modifications
Renamed the trait from "SwiftConfiguration" to "Configuration".
Result
Better trait name, aligned with the ecosystem.
Test Plan
PR CI.