Convenience closure to configure options inline with perform#86
Open
nakulbajaj wants to merge 1 commit intoapple:mainfrom
Open
Convenience closure to configure options inline with perform#86nakulbajaj wants to merge 1 commit intoapple:mainfrom
nakulbajaj wants to merge 1 commit intoapple:mainfrom
Conversation
nakulbajaj
requested review from
FranzBusch,
czechboy0,
fabianfett and
guoye-zhang
Contributor
|
Before including this in the API, could we first try to bring this up on the Swift Forums as a general feature for value types in Swift? I don't think we'd want to go and add this to every library's API. |
Contributor
|
Yeah, this is not an HTTP-specific problem and we should try to find a more general solution than a one-off sugar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed in #71 - I believe this is what we are looking for.