refactor(ui): remove survey abstractions, drop survey dependency#144
Open
blsmth wants to merge 1 commit into
Open
refactor(ui): remove survey abstractions, drop survey dependency#144blsmth wants to merge 1 commit into
blsmth wants to merge 1 commit into
Conversation
The survey-to-huh migration is complete (last call site landed in #135). Delete the survey-era plumbing in ui/questions.go: - QuestionExtra type - BooleanOptionProxy, MultiLineValueProxy, StringValueProxy - AskQuestions function - survey/v2 + survey/v2/core imports BooleanAsYesNo, PauseUntilEnter, and the huh helpers (YesNoOptions, YesNoToBool, PrintQuestionHeader) are retained — they have no survey dependency and are still used across stacks/ and cmd/. go mod tidy drops AlecAivazis/survey/v2 plus its transitive deps (Netflix/go-expect, hinshun/vt10x, kballard/go-shellquote, mgutz/ansi). Closes #124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The survey-to-huh migration is complete (last call site landed in #135). This drops the survey-era plumbing in
ui/questions.go:QuestionExtratypeBooleanOptionProxy,MultiLineValueProxy,StringValueProxyAskQuestionsfunctionsurvey/v2+survey/v2/coreimportsBooleanAsYesNo,PauseUntilEnter, and the huh helpers (YesNoOptions,YesNoToBool,PrintQuestionHeader) are retained — they have no survey dependency and are still used acrossstacks/andcmd/.go mod tidydropsAlecAivazis/survey/v2plus its transitive deps (Netflix/go-expect, hinshun/vt10x, kballard/go-shellquote, mgutz/ansi).Closes #124