chore(deps): raise the brace-expansion floor to 5.0.9 - #3146
Merged
Conversation
GHSA-rgw5-rvv9-x895 widened the affected range to <5.0.9, so the existing >=5.0.8 override stopped clearing it and the audit step in tests.yml now fails on every branch. Only the pinned floor and the resolved version move; integrity hashes are untouched.
Console (appwrite/console)Project ID: Sites (1)
Tip Preview deployments create instant URLs for every branch and commit |
Contributor
Greptile SummaryRaises the brace-expansion override floor from 5.0.8 to 5.0.9 to clear the updated security advisory and restore audit checks.
Confidence Score: 5/5The PR appears safe to merge, with the manifest and lockfile consistently applying the patched dependency floor. The override and sole locked brace-expansion resolution both use 5.0.9, and the existing minimatch dependency range accepts that version. Important Files Changed
Reviews (1): Last reviewed commit: "chore(deps): raise the brace-expansion f..." | Re-trigger Greptile |
atharvadeosthale
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
bun audit --audit-level high(.github/workflows/tests.yml:24) is failing on every branch, so thebuildjob is red repo-wide:package.jsonalready carries abrace-expansionoverride, pinned at>=5.0.8. GHSA-rgw5-rvv9-x895 widened the affected range to<5.0.9, so that floor stopped clearing the advisory and the lock stayed on the now-vulnerable 5.0.8. This raises the floor to>=5.0.9, matching the existing security-override pattern in that block.All reachable paths are dev-only (eslint, typescript-eslint,
@sentry/vite-plugin), so nothing ships to users — but the job is red, which blocks unrelated PRs.Test Plan
Three lines: the pinned floor, and the resolved version plus its integrity hash.
bun audit --audit-level high→ exit 0, no vulnerabilities.bun install --dry-run --frozen-lockfile→ exit 0, so the lock is still consistent withpackage.json.Worth noting for reviewers: running
bun install --lockfile-onlyto regenerate the lock silently dropped the integrity hashes from the three private-registry@appwrite.io/*entries (console,pink-svelte,pink-icons-svelte), presumably becausepkg.vcwas not authenticated locally. I discarded that and edited the twobrace-expansionlines directly so those hashes are preserved — the diff above confirms nothing else moved. Anyone regenerating this lock without registry auth should watch for the same thing.Related PRs and Issues
buildjob on fix(messaging): show delete for a processing message #3145 and any other open PR.