Conversation
WalkthroughThis pull request updates the Appwrite SDK version from 0.23.1 to 0.24.0 across the package manifest and client SDK header. It introduces two new public static query builder methods to the Query class: Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
src/query.ts (2)
148-148: Optional: renamevalue→valuesto match the array-parameter convention in the class.All other methods in
Querythat accept an array parameter use the plural namevalues(intersects,elemMatch,exists,notExists,select,distanceEqual, etc.).containsAnyandcontainsAllusevalue(singular) forany[], creating an inconsistency.♻️ Proposed rename
- static containsAny = (attribute: string, value: any[]): string => - new Query("containsAny", attribute, value).toString(); + static containsAny = (attribute: string, values: any[]): string => + new Query("containsAny", attribute, values).toString();- static containsAll = (attribute: string, value: any[]): string => - new Query("containsAll", attribute, value).toString(); + static containsAll = (attribute: string, values: any[]): string => + new Query("containsAll", attribute, values).toString();Also update the
@paramtags accordingly:- * `@param` {any[]} value + * `@param` {any[]} valuesAlso applies to: 160-160
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/query.ts` at line 148, Rename the array parameter name from value to values in the static methods Query.containsAny and Query.containsAll to match the class convention; update the method signatures and all internal references from value → values and adjust the JSDoc `@param` tags to refer to values so documentation and code stay consistent with other methods like intersects, elemMatch, exists, notExists, select, and distanceEqual.
129-131: Optional: qualify{@link}references with the class name for reliable tooling resolution.
{@linkcontainsAny}and{@linkcontainsAll}are bare symbol references. Some documentation generators (TypeDoc, VS Code IntelliSense) resolve these more reliably when fully qualified as{@linkQuery.containsAny}.♻️ Proposed fix
- * Note: For array attributes, use {`@link` containsAny} or {`@link` containsAll} instead. + * Note: For array attributes, use {`@link` Query.containsAny} or {`@link` Query.containsAll} instead.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/query.ts` around lines 129 - 131, Update the JSDoc at the method describing string/array attribute checks to fully qualify the referenced methods so tooling can resolve them: replace the bare {`@link` containsAny} and {`@link` containsAll} with {`@link` Query.containsAny} and {`@link` Query.containsAll} in the comment near the string-attribute docs (the docblock mentioning "For array attributes, use {`@link` containsAny} or {`@link` containsAll} instead.") so tools like TypeDoc/IntelliSense can correctly link to the methods.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/query.ts`:
- Line 148: Rename the array parameter name from value to values in the static
methods Query.containsAny and Query.containsAll to match the class convention;
update the method signatures and all internal references from value → values and
adjust the JSDoc `@param` tags to refer to values so documentation and code stay
consistent with other methods like intersects, elemMatch, exists, notExists,
select, and distanceEqual.
- Around line 129-131: Update the JSDoc at the method describing string/array
attribute checks to fully qualify the referenced methods so tooling can resolve
them: replace the bare {`@link` containsAny} and {`@link` containsAll} with {`@link`
Query.containsAny} and {`@link` Query.containsAll} in the comment near the
string-attribute docs (the docblock mentioning "For array attributes, use {`@link`
containsAny} or {`@link` containsAll} instead.") so tools like
TypeDoc/IntelliSense can correctly link to the methods.
This PR contains updates to the React Native SDK for version 0.24.0 .