Skip to content

fix: find locale params in render calls #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisberthe merged 1 commit into from
Apr 25, 2025
Merged

fix: find locale params in render calls #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/utilities/locales.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,13 @@ function extractStorefrontTranslationKeys(content: string): Set<string> {
}
}

// Find all locale: parameters in any render call
const localePattern = /render\s+["'][^"']+["'][\S\s]*?locale:\s*["']([^"']+)["']/g
const localeMatches = [...content.matchAll(localePattern)]
for (const match of localeMatches) {
keys.add(match[1])
}

// Combine with utility.translate translations
return new Set([...keys, ...extractUtilityTranslateKeys(content)])
}
Expand Down