Skip to content

refactor: Use theme blocks for PDP #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
t-kelly wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor: Use theme blocks for PDP #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18ce9cc
refactor: Use theme blocks for PDP
t-kelly Mar 27, 2025
b64b213
Install the updated components
t-kelly Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
.collections
.locales
.shopify
4 changes: 0 additions & 4 deletions assets/component.block-variant-picker.css
View file
Open in desktop

This file was deleted.

0 assets/component.block-buy-buttons.css → assets/product.block.buy-buttons.css
View file
Open in desktop
File renamed without changes.
0 assets/component.block-buy-buttons.js → assets/product.block.buy-buttons.js
View file
Open in desktop
File renamed without changes.
0 assets/component.product-media-gallery.css → assets/product.block.media-gallery.css
View file
Open in desktop
File renamed without changes.
0 assets/component.product-media-gallery.js → assets/product.block.media-gallery.js
View file
Open in desktop
File renamed without changes.
0 assets/component.block-price.css → assets/product.block.price.css
View file
Open in desktop
File renamed without changes.
0 assets/component.block-price.js → assets/product.block.price.js
View file
Open in desktop
File renamed without changes.
0 assets/component.block-title.css → assets/product.block.title.css
View file
Open in desktop
File renamed without changes.
0 assets/component.variant-sku.js → assets/product.block.title.sku.js
View file
Open in desktop
File renamed without changes.
5 changes: 5 additions & 0 deletions assets/component.variant-button.css → assets/product.block.variant-picker.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
.block-variant-picker {
display: grid;
gap: var(--size-6);
}

.variant-button {
--label-bottom-margin: var(--size-3);

Expand Down
0 assets/component.block-variant-picker.js → assets/product.block.variant-picker.js
View file
Open in desktop
File renamed without changes.
17 changes: 17 additions & 0 deletions blocks/_product-buy-buttons.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{% render 'product.block.buy-buttons' %}

{% schema %}
{
"name": "t:labels.buy_buttons",
"settings": [
{
"type": "checkbox",
"id": "show_dynamic_checkout",
"label": "t:actions.show_dynamic_checkout",
"default": true,
"info": "t:info.lets_customers_checkout_familiar"
}
]
}
{% endschema %}

7 changes: 7 additions & 0 deletions blocks/_product-description.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{%- render 'product.block.description', product: product -%}

{% schema %}
{
"name": "t:labels.description"
}
{% endschema %}
7 changes: 7 additions & 0 deletions blocks/_product-media-gallery.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{% render 'product.block.media-gallery' %}

{% schema %}
{
"name": "Product Media Gallery"
}
{% endschema %}
7 changes: 7 additions & 0 deletions blocks/_product-price.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{% render 'product.block.price' %}

{% schema %}
{
"name": "t:labels.price"
}
{% endschema %}
20 changes: 20 additions & 0 deletions blocks/_product-title.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{% render 'product.block.title' %}

{% schema %}
{
"name": "t:labels.title",
"settings": [
{
"type": "checkbox",
"id": "vendor_enable",
"label": "t:actions.show_vendor"
},
{
"type": "checkbox",
"id": "sku_enable",
"label": "t:actions.show_sku",
"default": true
}
]
}
{% endschema %}
25 changes: 25 additions & 0 deletions blocks/_product-variant-picker.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{% render 'product.block.variant-picker' %}

{% schema %}
{
"name": "Variant picker",
"settings": [
{
"type": "select",
"id": "picker_type",
"label": "t:labels.type",
"options": [
{
"value": "button",
"label": "t:labels.buttons"
},
{
"value": "dropdown",
"label": "t:labels.dropdown"
}
],
"default": "button"
}
]
}
{% endschema %}
45 changes: 22 additions & 23 deletions component.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"collections": {
"@archetype-themes/reference-components": {
"commit": "ec57c3ff897f9dd4e6ddde29d6a4e45dc027b3b4",
"version": "2.0.0"
}
},
Expand All @@ -10,8 +11,6 @@
"base.document.css": "@archetype-themes/reference-components",
"base.normalize.css": "@archetype-themes/reference-components",
"base.typography.css": "@archetype-themes/reference-components",
"component.block-buy-buttons.css": "@archetype-themes/reference-components",
"component.block-buy-buttons.js": "@archetype-themes/reference-components",
"component.block-cart-checkout-button.css": "@archetype-themes/reference-components",
"component.block-cart-note.css": "@archetype-themes/reference-components",
"component.block-cart-note.js": "@archetype-themes/reference-components",
Expand All @@ -20,12 +19,7 @@
"component.block-image.css": "@archetype-themes/reference-components",
"component.block-model.css": "@archetype-themes/reference-components",
"component.block-model.js": "@archetype-themes/reference-components",
"component.block-price.css": "@archetype-themes/reference-components",
"component.block-price.js": "@archetype-themes/reference-components",
"component.block-rich-text.css": "@archetype-themes/reference-components",
"component.block-title.css": "@archetype-themes/reference-components",
"component.block-variant-picker.css": "@archetype-themes/reference-components",
"component.block-variant-picker.js": "@archetype-themes/reference-components",
"component.block-video.css": "@archetype-themes/reference-components",
"component.block-video.js": "@archetype-themes/reference-components",
"component.button.css": "@archetype-themes/reference-components",
Expand All @@ -40,21 +34,27 @@
"component.line-item.css": "@archetype-themes/reference-components",
"component.model-viewer.css": "@archetype-themes/reference-components",
"component.placeholder-svg.css": "@archetype-themes/reference-components",
"component.product-media-gallery.css": "@archetype-themes/reference-components",
"component.product-media-gallery.js": "@archetype-themes/reference-components",
"component.rte.css": "@archetype-themes/reference-components",
"component.section-header.css": "@archetype-themes/reference-components",
"component.section-main-cart.css": "@archetype-themes/reference-components",
"component.section-main-product.css": "@archetype-themes/reference-components",
"component.section-media-with-text.css": "@archetype-themes/reference-components",
"component.select.css": "@archetype-themes/reference-components",
"component.variant-button.css": "@archetype-themes/reference-components",
"component.variant-sku.js": "@archetype-themes/reference-components",
"element.base-media.js": "@archetype-themes/reference-components",
"icon.alert.svg": "@archetype-themes/reference-components",
"icon.bag.svg": "@archetype-themes/reference-components",
"icon.caret.svg": "@archetype-themes/reference-components",
"icon.cart.svg": "@archetype-themes/reference-components",
"product.block.buy-buttons.css": "@archetype-themes/reference-components",
"product.block.buy-buttons.js": "@archetype-themes/reference-components",
"product.block.media-gallery.css": "@archetype-themes/reference-components",
"product.block.media-gallery.js": "@archetype-themes/reference-components",
"product.block.price.css": "@archetype-themes/reference-components",
"product.block.price.js": "@archetype-themes/reference-components",
"product.block.title.css": "@archetype-themes/reference-components",
"product.block.title.sku.js": "@archetype-themes/reference-components",
"product.block.variant-picker.css": "@archetype-themes/reference-components",
"product.block.variant-picker.js": "@archetype-themes/reference-components",
"util.aspect-ratio.css": "@archetype-themes/reference-components",
"util.clearfix.css": "@archetype-themes/reference-components",
"util.display.css": "@archetype-themes/reference-components",
Expand All @@ -70,17 +70,12 @@
"vendor.is-land.min.js": "@archetype-themes/reference-components"
},
"snippets": {
"block-buy-buttons.liquid": "@archetype-themes/reference-components",
"block-cart-checkout-button.liquid": "@archetype-themes/reference-components",
"block-cart-note.liquid": "@archetype-themes/reference-components",
"block-cart-totals.liquid": "@archetype-themes/reference-components",
"block-image.liquid": "@archetype-themes/reference-components",
"block-model.liquid": "@archetype-themes/reference-components",
"block-price.liquid": "@archetype-themes/reference-components",
"block-product-description.liquid": "@archetype-themes/reference-components",
"block-rich-text.liquid": "@archetype-themes/reference-components",
"block-title.liquid": "@archetype-themes/reference-components",
"block-variant-picker.liquid": "@archetype-themes/reference-components",
"block-video.liquid": "@archetype-themes/reference-components",
"cart-icon.liquid": "@archetype-themes/reference-components",
"cart-status-notifier.liquid": "@archetype-themes/reference-components",
Expand All @@ -96,19 +91,23 @@
"line-item-quantity.liquid": "@archetype-themes/reference-components",
"line-item.liquid": "@archetype-themes/reference-components",
"price.liquid": "@archetype-themes/reference-components",
"product-description.liquid": "@archetype-themes/reference-components",
"product-media-gallery.liquid": "@archetype-themes/reference-components",
"product.block.buy-buttons.liquid": "@archetype-themes/reference-components",
"product.block.description.liquid": "@archetype-themes/reference-components",
"product.block.media-gallery.liquid": "@archetype-themes/reference-components",
"product.block.price.liquid": "@archetype-themes/reference-components",
"product.block.title.liquid": "@archetype-themes/reference-components",
"product.block.title.sku.liquid": "@archetype-themes/reference-components",
"product.block.variant-picker.button.liquid": "@archetype-themes/reference-components",
"product.block.variant-picker.dropdown.liquid": "@archetype-themes/reference-components",
"product.block.variant-picker.liquid": "@archetype-themes/reference-components",
"product.section.main.liquid": "@archetype-themes/reference-components",
"section-header.liquid": "@archetype-themes/reference-components",
"section-main-cart.liquid": "@archetype-themes/reference-components",
"section-main-product.liquid": "@archetype-themes/reference-components",
"section-media-with-text.liquid": "@archetype-themes/reference-components",
"styles-head.liquid": "@archetype-themes/reference-components",
"styles-tokens.liquid": "@archetype-themes/reference-components",
"stylesheet.liquid": "@archetype-themes/reference-components",
"t-with-fallback.liquid": "@archetype-themes/reference-components",
"variant-button.liquid": "@archetype-themes/reference-components",
"variant-dropdown.liquid": "@archetype-themes/reference-components",
"variant-sku.liquid": "@archetype-themes/reference-components"
"t-with-fallback.liquid": "@archetype-themes/reference-components"
}
}
}
105 changes: 19 additions & 86 deletions sections/main-product.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,21 @@
{%- liquid
capture blocks
for block in section.blocks
case block.type
when '@app'
render block
when 'description'
render 'block-product-description', block: block
when 'variant_picker'
render 'block-variant-picker', block: block
when 'buy_buttons'
render 'block-buy-buttons', block: block
when 'title'
render 'block-title', block: block
when 'price'
render 'block-price', block: block
endcase
endfor
content_for 'blocks'
endcapture

render 'section-main-product', slot_product_blocks: blocks
-%}
render 'product.section.main', slot_product_blocks: blocks
-%}

{% schema %}
{
"name": "t:labels.product",
"blocks": [
{ "type": "_product-buy-buttons" },
{ "type": "_product-description" },
{ "type": "_product-price" },
{ "type": "_product-title" },
{ "type": "_product-variant-picker" }
],
"settings": [
{
"type": "header",
Expand All @@ -50,74 +42,15 @@
"default": "left"
}
],
"blocks": [
{
"type": "@app"
},
{
"type": "title",
"name": "t:labels.title",
"limit": 1,
"settings": [
{
"type": "checkbox",
"id": "vendor_enable",
"label": "t:actions.show_vendor"
},
{
"type": "checkbox",
"id": "sku_enable",
"label": "t:actions.show_sku",
"default": true
}
]
},
{
"type": "price",
"name": "t:labels.price",
"limit": 1
},
{
"type": "description",
"name": "t:labels.description",
"limit": 1,
"settings": []
},
{
"type": "variant_picker",
"name": "Variant picker",
"limit": 1,
"settings": [
{
"type": "select",
"id": "picker_type",
"label": "t:labels.type",
"options": [
{
"value": "button",
"label": "t:labels.buttons"
},
{
"value": "dropdown",
"label": "t:labels.dropdown"
}
],
"default": "button"
}
]
},
{
"type": "buy_buttons",
"name": "t:labels.buy_buttons",
"limit": 1,
"settings": [
{
"type": "checkbox",
"id": "show_dynamic_checkout",
"label": "t:actions.show_dynamic_checkout",
"default": true,
"info": "t:info.lets_customers_checkout_familiar"
}
"presets": [
{
"name": "t:labels.product",
"blocks": [
{ "type": "_product-title" },
{ "type": "_product-price" },
{ "type": "_product-variant-picker" },
{ "type": "_product-description" },
{ "type": "_product-buy-buttons" }
]
}
]
Expand Down
18 changes: 0 additions & 18 deletions snippets/block-product-description.liquid
View file
Open in desktop

This file was deleted.

10 changes: 5 additions & 5 deletions snippets/import-map.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
<script type="importmap">
{
"imports": {
"component.block-buy-buttons": "{{ 'component.block-buy-buttons.js' | asset_url }}",
"component.block-cart-note": "{{ 'component.block-cart-note.js' | asset_url }}",
"component.block-cart-totals": "{{ 'component.block-cart-totals.js' | asset_url }}",
"component.block-model": "{{ 'component.block-model.js' | asset_url }}",
"component.block-price": "{{ 'component.block-price.js' | asset_url }}",
"component.block-variant-picker": "{{ 'component.block-variant-picker.js' | asset_url }}",
"component.block-video": "{{ 'component.block-video.js' | asset_url }}",
"component.cart-icon": "{{ 'component.cart-icon.js' | asset_url }}",
"component.cart-status-notifier": "{{ 'component.cart-status-notifier.js' | asset_url }}",
"component.line-item-price": "{{ 'component.line-item-price.js' | asset_url }}",
"component.line-item-quantity": "{{ 'component.line-item-quantity.js' | asset_url }}",
"component.product-media-gallery": "{{ 'component.product-media-gallery.js' | asset_url }}",
"component.variant-sku": "{{ 'component.variant-sku.js' | asset_url }}",
"element.base-media": "{{ 'element.base-media.js' | asset_url }}",
"product.block.buy-buttons": "{{ 'product.block.buy-buttons.js' | asset_url }}",
"product.block.media-gallery": "{{ 'product.block.media-gallery.js' | asset_url }}",
"product.block.price": "{{ 'product.block.price.js' | asset_url }}",
"product.block.title.sku": "{{ 'product.block.title.sku.js' | asset_url }}",
"product.block.variant-picker": "{{ 'product.block.variant-picker.js' | asset_url }}",
"util.product-loader": "{{ 'util.product-loader.js' | asset_url }}",
"util.pubsub": "{{ 'util.pubsub.js' | asset_url }}",
"util.script-loader": "{{ 'util.script-loader.js' | asset_url }}",
Expand Down
Loading