Move mount() to disk.utils#4232
Merged
svartkanin merged 1 commit intoarchlinux:masterfrom Feb 16, 2026
Merged
Conversation
codefiles
commented
Feb 16, 2026
| def find_lsblk_info( | ||
| dev_path: Path | str, | ||
| info: list[LsblkInfo], | ||
| info_list: list[LsblkInfo], |
Contributor
Author
There was a problem hiding this comment.
This would seem like an unrelated change but with info being added to the imports just above this, pylint will give the following:
https://pylint.pycqa.org/en/latest/user_guide/messages/warning/redefined-outer-name.html
svartkanin
approved these changes
Feb 16, 2026
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4149
This is meant to work towards decoupling
device_handlerfrominstaller.pyso that importing it will not cause devices to be probed. None of thedevice_handlermethods used ininstaller.pyoperate on properties ofdevice_handlerso they do not need a device probe to function.