added methods to configure modbus server to existing data stuctures#52
Closed
ASolchen wants to merge 1 commit intoarduino-libraries:masterfrom
ASolchen:master
Closed
added methods to configure modbus server to existing data stuctures#52ASolchen wants to merge 1 commit intoarduino-libraries:masterfrom ASolchen:master
ASolchen wants to merge 1 commit intoarduino-libraries:masterfrom
ASolchen:master
Conversation
…ructs and example
|
Memory usage change @ f53379a
Click for full report table
Click for full report CSV |
|
|
Contributor
|
Thanks for this PR. I've been using it and loving it. |
Author
|
Thanks for the feedback. Happy to help!
…On Wed, Jun 2, 2021, 08:46 Nicholas Stedman ***@***.***> wrote:
Thanks for this PR. I've been using it and loving it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#52 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE3JUNSEDZ2WJIBFAKR6JXLTQYYZPANCNFSM42AZ7OCQ>
.
|
Author
|
I've tried signing the CLA several times. It still shows "not signed yet." |
Contributor
Hi @ASolchen. Thanks so much for your pull request. The problem with the CLA is that the commit is by @testtechsolutions, not by your @ASolchen user. The email address of the user signing the CLA must match to that of the author of the commit. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With memory being tight on most micro controllers, I felt like I shouldn't have to allocate memory for modbus to use, but instead point the server at existing data structures. If the structures are not of the same type, the user can cast it as such.