refactor(deps): replace unmaintained pkg/errors with fmt.Errorf#747
Merged
agilgur5 merged 1 commit intoargoproj:masterfrom Oct 20, 2024
Merged
refactor(deps): replace unmaintained pkg/errors with fmt.Errorf#747agilgur5 merged 1 commit intoargoproj:masterfrom
pkg/errors with fmt.Errorf#747agilgur5 merged 1 commit intoargoproj:masterfrom
Conversation
Signed-off-by: william.vanhevelingen <william.vanhevelingen@acquia.com>
blkperl
added
dependencies
This comment was marked as resolved.
This comment was marked as resolved.
agilgur5
reviewed
Oct 20, 2024
| // SetLogLevel parses and sets a logrus log level | ||
| func SetLogLevel(logLevel string) { | ||
| level, err := log.ParseLevel(logLevel) | ||
| errors.CheckError(err) |
There was a problem hiding this comment.
Do you want to delete the CheckError function and the internal errors package entirely?
I suppose that would be a breaking change worth separating out into its own PR anyway though
agilgur5
approved these changes
Oct 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses argoproj/argo-workflows#13673 (comment)