Ubuntu Resolute requires that there be a "scripts/mod/modpost" binary… #8996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… during header compilation Signed-off-by: Patrick Yavitz <[email protected]>
github-actions
bot
added
11
Contributor
WalkthroughA conditional copy operation is added to the linux-headers packaging process in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (6)📓 Common learnings📚 Learning: 2025-09-27T21:50:04.845ZApplied to files:
📚 Learning: 2025-09-27T21:47:58.020ZApplied to files:
📚 Learning: 2025-09-27T21:49:55.796ZApplied to files:
📚 Learning: 2025-09-22T21:52:01.225ZApplied to files:
📚 Learning: 2025-09-22T21:52:01.225ZApplied to files:
🧬 Code graph analysis (1)lib/functions/compilation/kernel-debs.sh (1)
🔇 Additional comments (1)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
Needs review
Collaborator
Author
Member
|
After reverting previously mentioned problem, i get further, but then it fails: |
rpardini
requested changes
Nov 26, 2025
|
|
||
| # Ubuntu Resolute requires that there be a "scripts/mod/modpost" binary during header compilation | ||
| [[ -f "${kernel_work_dir}/scripts/mod/modpost" ]] && | ||
| run_host_command_logged cp -v "${kernel_work_dir}/scripts/mod/modpost" "${headers_target_dir}/scripts/mod/modpost" |
Member
There was a problem hiding this comment.
The problem here is under cross-compilation: if kernel is for arm64 but is built say on amd64, the headers package will end up with a wrong architecture binary.
Instead, we would need to ship enough sources so that the modpost binary can be built board-side during linux-headers install, like the others.
I've very similar issue with resolve_btfids, but that one is easy since we already ship enough sources to build it there.
Or: just wait until all Armbian kernels are 6.12+, and get rid of this whole packaging code (instead just do make bindeb).
Collaborator
Author
There was a problem hiding this comment.
The problem here is under cross-compilation: if kernel is for arm64 but is built say on amd64, the headers package will end up with a wrong architecture binary.
Hmm. Ur right. So this isn't gonna work as is. I'm not sure how using make bindeb would change anything, as I already use make bindeb-pkg on my personal builds.
I am curious, which is something Igor touched on... "why Resolute"? Doesn't appear to be an issue on other releases.
Member
There was a problem hiding this comment.
I meant "one day we can make Armbian use the kernel's own .deb packaging", as 6.12 landed support for cross-compiled headers -- the whole reason Armbian re-invented deb packaging square. (Originally, each Armbian kernel had patches for the packaging, and bumping kernels was hell).
I'll take a look to see if I can make the linux-headers install produce modpost and resolve_btfids binaries on install without having to ship the whole of linux source in linux-headers.
Ref resolute: no idea. I've not touched Ubuntu since noble.
Collaborator
Author
There was a problem hiding this comment.
I see what you mean. I just ran a test doing it the new way which requires debhelper and libssl-dev:$arch to be installed and the headers came out clean.
Collaborator
Author
There was a problem hiding this comment.
They have also removed the *-static suffix from qemu; `https://git.launchpad.net/ubuntu/+source/qemu/tree/debian/qemu-user-static.NEWS?h=ubuntu/plucky
Current package lineup; binfmt-support qemu-user qemu-user-binfmt
Of course this only relates to using Questing and Resolute as a host.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu Resolute
Fail: https://paste.armbian.com/bacifoqope.bash
Success: https://paste.armbian.com/picelafexa.bash
NOTE: For reasons I am unable to generate a Ubuntu Resolute Armbian Image. Tests were run in a chroot after debootstraping Ubuntu Resolute.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.