Fix concurrent index migrations with schema-driven multitenancy #610#685
Closed
RylandBangerter85 wants to merge 0 commit intoash-project:mainfrom
Closed
Fix concurrent index migrations with schema-driven multitenancy #610#685RylandBangerter85 wants to merge 0 commit intoash-project:mainfrom
RylandBangerter85 wants to merge 0 commit intoash-project:mainfrom
Conversation
Author
|
Is there anything that needs to be changed for this PR? It was submitted almost two weeks ago and I haven't seen anything, so I just wanted to make sure. |
zachdaniel
reviewed
Feb 18, 2026
lib/multitenancy.ex
Outdated
| defp migration_requires_no_transaction?(file, mod) do | ||
| # First check the file content for @disable_ddl_transaction | ||
| file_content = File.read!(file) | ||
| has_disable_ddl_transaction? = String.contains?(file_content, "@disable_ddl_transaction") |
Contributor
There was a problem hiding this comment.
Do we really need to check both? If the module is compiled we ought to be able to just ask the module and not bother looking at the file, since they could theoretically do Module.put_attribute(__MODULE__, :disable_ddl_transaction, true)
RylandBangerter85
force-pushed
the
fix-concurrent-index-multitenancy
branch
from
f433072 to
afb3a5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where CREATE INDEX CONCURRENTLY fails when creating tenants
Contributor checklist
Leave anything that you believe does not apply unchecked.