fix(lexarg): Iterate on the design #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Pull Request Test Coverage Report for Build 14110839856Details
💛 - Coveralls |
Unsure why I made this deviation for lexopt
From lexopt
> If we find "-=[...]" we interpret it as an option.
> If we find "-o=..." then there's an unexpected value.
> ('-=' as an option exists, see https://linux.die.net/man/1/a2ps.)
> clap always interprets it as a short flag in this case, but
> that feels sloppy.
If `=` is a short in one position, it makes sense for it to be a short
in another position, so we're "being sloppy".
This provides span information and allows users to do more custom logic with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In re-familiaizing myself with the code, I'm starting with the bottom: the CLI parser.
This is a first pass for doing some clean up, trying to focus on the core of what is needed or not needed. Some more passes will be needed.