Add a check for accidental cache modifications #16927
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstin
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
konstin
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
Member
|
Related #1699 cc @BurntSushi |
Add a script and associated CI check that checks whether a new uv build can use the cache of the previous uv version. This prevents accidental changes to cache keys, e.g. by changing nested data structures. I've tested the script by using a previous change of #16143. The check can be disabled with a PR label for PRs that change the cache layout. What's missing here is that the base is the last release, meaning that once a PR with that label merges, all following PRs will fail this check, as we currently don't have a good way to ask whether there was a change previously or to download the latest build binary from main as baseline.
konstin
force-pushed
the
konsti/check-cache-changes
branch
from
68c03b7 to
b7e5ac2
Compare
konstin
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
konstin
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
Member
Author
|
I'm taking suggestions if someone has ideas how we can solve the previously-PR-changes the cache problem. We can check the GitHub API if any PR merged between last release and base had the cache-change label, but that sounds complex, and doesn't capture repeat changes in other PRs. Another option is storing the latest binary builds from main as nightly somewhere. |
Member
I kinda like this. Also independently useful. Another idea: what about cloning current |
Member
Author
|
CI performance mainly, but you're right that it's a very straightforward solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a script and associated CI check that checks whether a new uv build can use the cache of the previous uv version. This prevents accidental changes to cache keys, e.g. by changing nested data structures.
I've tested the script by using a previous change of #16143.
The check can be disabled with a PR label for PRs that change the cache layout. What's missing here is that the base is the last release, meaning that once a PR with that label merges, all following PRs will fail this check, as we currently don't have a good way to ask whether there was a change previously or to download the latest build binary from main as baseline.