Skip to content

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Dec 3, 2025

It'd be nice to avoid churn for contributors. This is a pretty frequent cause of CI failures and I don't think we really need to have the reference documentation committed.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 3, 2025

CodSpeed Performance Report

Merging #16969 will not alter performance

Comparing zb/gen-all (ce29531) with main (28a8194)

Summary

✅ 5 untouched

run: cargo dev generate-all --mode check
run: cargo dev generate-all --mode dry-run
- name: "Check sysconfig mappings"
run: cargo dev generate-sysconfig-metadata --mode check
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still retain / commit the sysconfig metadata

@zanieb zanieb marked this pull request as ready for review December 3, 2025 15:28
@zanieb zanieb requested a review from konstin December 4, 2025 15:34
@konstin konstin added the internal A refactor or improvement that is not user-facing label Dec 8, 2025
@konstin
Copy link
Member

konstin commented Dec 8, 2025

It would be great to have a way to check the generated documentation - we had incorrect rendering before - unfortunately, having the files added to git didn't help with that really.

@zanieb
Copy link
Member Author

zanieb commented Dec 8, 2025

Yeah I think if we're uncertain about the rendering we'll just need to run mkdocs locally anyway, unless we add preview environments for documentation.

@zanieb zanieb temporarily deployed to uv-test-registries December 8, 2025 12:21 — with GitHub Actions Inactive
@zanieb zanieb temporarily deployed to uv-test-publish December 8, 2025 12:21 — with GitHub Actions Inactive
@zanieb zanieb enabled auto-merge (squash) December 8, 2025 12:26
@zanieb zanieb merged commit 5a6f2ea into main Dec 8, 2025
101 checks passed
@zanieb zanieb deleted the zb/gen-all branch December 8, 2025 12:31
zanieb added a commit that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants