-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Generate reference documentation at publish-time and the JSON schema at release-time #16969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #16969 will not alter performanceComparing Summary
|
| run: cargo dev generate-all --mode check | ||
| run: cargo dev generate-all --mode dry-run | ||
| - name: "Check sysconfig mappings" | ||
| run: cargo dev generate-sysconfig-metadata --mode check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still retain / commit the sysconfig metadata
|
It would be great to have a way to check the generated documentation - we had incorrect rendering before - unfortunately, having the files added to git didn't help with that really. |
|
Yeah I think if we're uncertain about the rendering we'll just need to run mkdocs locally anyway, unless we add preview environments for documentation. |
It'd be nice to avoid churn for contributors. This is a pretty frequent cause of CI failures and I don't think we really need to have the reference documentation committed.