Honor --refresh when reusing cached tool environments for uvx/uv tool run
#16991
Conversation
| if let Ok(root) = cache.resolve_link(cache_entry.path()) { | ||
| if let Ok(environment) = PythonEnvironment::from_root(root, cache) { | ||
| return Ok(Self(environment)); | ||
| if cache.freshness(&cache_entry, None, None)?.is_fresh() { |
There was a problem hiding this comment.
Previous errors were swallowed here... I'm thinking we should do the same for the freshness check? 🤔
There was a problem hiding this comment.
What causes the freshness check to fail? is_ok_and could be fine 🤷♀️ but it depends on the failure conditions
There was a problem hiding this comment.
Permission denied or other I/O related errors when reading the cache entry's metadata could occur. These are probably rare edge cases, and if we can't even read the metadata of a cache entry, falling through to rebuild seems reasonable to me.
|
@zanieb Thinking about this change more (after looking at a few existing tests), it looks like re-using the cache for |
|
I think @charliermarsh probably has the most context on the existing behavior. |
2 participants
Resolves #16974
This diff consults the cache’s freshness policy before reusing a cached tool environment, so
--refresh(and package-specific refresh flags) actually invalidate stale envs instead of silently reusing them. Previously, local projects with unchanged versions kept running old code because the cached env was always treated as fresh; the change implemented here forces a rebuild when refresh is requested.