AXON-1601: Issue editing still allowed after logout in another tab #1378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![atlassian[bot]](https://avatars.githubusercontent.com/in/14320?s=60&v=4){kind=small}
src/webviews/components/issue/view-issue-screen/JiraIssuePage.tsx
Outdated
Show resolved
Hide resolved
sspanchenko
force-pushed
the
AXON-1601-issue-editing-still-allowed-after-logout
branch
from
c4a78de to
79ba56e
Compare
| siteDetails: mockSiteDetails, | ||
| apiVersion: 3, | ||
| isOnline: true, | ||
| isLoggedOut, |
Contributor
There was a problem hiding this comment.
🔎 Testing
The test is passing isLoggedOut in the 'update' message but the real implementation expects this state to be set via a separate 'loggedOut' message type.
sspanchenko
requested review from
Blastoplex,
amarg-at,
bhorai-atl,
bwieger-atlassian-com,
cabella-dot,
ccallcottstevens,
dchiew-atl,
jwang19-atlassian,
marcomura,
matt-lassian,
om-ukr,
sdzh-atlassian and
teg-atlassian
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is This Change?
We must prevent the editing of a Jira issue if the user has already logged out in a separate VS Code tab
How Has This Been Tested?
Basic checks:
npm run lintnpm run testAdvanced checks:
Recommendations: