-
Notifications
You must be signed in to change notification settings - Fork 3
fix: update AtomicSDK version to 3.27.2 with vendored_frameworks #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9d3c323
fix: update AtomicSDK version to 3.27.2 with vendored_frameworks
brax10ward e027f00
chore: add build action
brax10ward 96a0b32
chore: trim the build workflow
brax10ward 9ddebae
chore: use nvmrc in build action
brax10ward e634188
chore: cleanup update-ios-sdk
brax10ward b7b6791
chore: use workflow_call instead of respository_dispatch
brax10ward File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,185 @@ | ||
| name: React Native | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [master] | ||
|
|
||
| env: | ||
| EXPO_TOKEN: ${{ secrets.EXPO_TOKEN }} | ||
| EXPO_APPLE_ID: ${{ secrets.EXPO_APPLE_ID }} | ||
| EXPO_APPLE_PASSWORD: ${{ secrets.EXPO_APPLE_PASSWORD }} | ||
| EXPO_TEAM_ID: ${{ secrets.EXPO_TEAM_ID }} | ||
| NODE_OPTIONS: --openssl-legacy-provider | ||
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: 🏗 Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: 🏗 Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: ".nvmrc" | ||
| cache: "yarn" | ||
|
|
||
| - name: 📦 Get yarn cache directory path | ||
| id: yarn-cache-dir-path | ||
| run: echo "dir=$(yarn config get cacheFolder)" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: 📦 Setup yarn cache | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: ${{ steps.yarn-cache-dir-path.outputs.dir }} | ||
| key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-yarn- | ||
|
|
||
| - name: 📦 Install dependencies | ||
| run: yarn install | ||
|
|
||
| - name: 🧪 Run TypeScript check | ||
| run: yarn tsc | ||
|
|
||
| - name: 🧹 Run ESLint | ||
| run: yarn lint | ||
|
|
||
| build-android: | ||
| needs: lint | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: 🏗 Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: 🏗 Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: ".nvmrc" | ||
| cache: "yarn" | ||
|
|
||
| - name: 📦 Get yarn cache directory path | ||
| id: yarn-cache-dir-path | ||
| run: echo "dir=$(yarn config get cacheFolder)" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: 📦 Setup yarn cache | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: ${{ steps.yarn-cache-dir-path.outputs.dir }} | ||
| key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-yarn- | ||
|
|
||
| - name: 📦 Install dependencies | ||
| run: yarn install | ||
|
|
||
| - name: 🔄 Verify EAS CLI installation | ||
| run: | | ||
| echo "EAS CLI version:" | ||
| yarn dlx eas-cli@latest --version | ||
|
|
||
| - name: 📋 Fix package.json main entry | ||
| working-directory: ./example | ||
| run: | | ||
| # EAS local builds require `main` to be "node_modules/expo/AppEntry.js". | ||
| # The checked-in value ("index.ts") works for local dev with Metro/Expo Go | ||
| # but causes EAS to fail to resolve the entry point during a local build. | ||
| # Check if jq is installed, if not install it | ||
| if ! command -v jq &> /dev/null; then | ||
| echo "Installing jq..." | ||
| sudo apt-get update && sudo apt-get install -y jq | ||
| fi | ||
|
|
||
| # Fix the main entry in package.json | ||
| if [ -f ./package.json ]; then | ||
| # Create a backup | ||
| cp package.json package.json.bak | ||
| # Update the package.json | ||
| jq '.main = "node_modules/expo/AppEntry.js"' package.json > package.json.tmp && mv package.json.tmp package.json | ||
| echo "Updated package.json main entry" | ||
| cat package.json | grep "main" | ||
| else | ||
| echo "package.json not found" | ||
| exit 1 | ||
| fi | ||
|
|
||
| - name: 📱 Build Android Dev .apk | ||
| working-directory: ./example | ||
| run: | | ||
| export NODE_OPTIONS="--openssl-legacy-provider --max_old_space_size=4096" | ||
| yarn dlx eas-cli@latest build --platform android --profile development --local --non-interactive --output=./app-dev.apk | ||
| env: | ||
| NODE_ENV: development | ||
|
|
||
| - name: 📦 Upload build artifact to GitHub | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: app-builds-android | ||
| path: ./example/app-dev.apk | ||
| retention-days: 7 | ||
|
|
||
| build-ios: | ||
| needs: lint | ||
| runs-on: macos-latest | ||
| steps: | ||
| - name: 🏗 Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: 🏗 Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: ".nvmrc" | ||
| cache: "yarn" | ||
|
|
||
| - name: 📦 Get yarn cache directory path | ||
| id: yarn-cache-dir-path | ||
| run: echo "dir=$(yarn config get cacheFolder)" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: 📦 Setup yarn cache | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: ${{ steps.yarn-cache-dir-path.outputs.dir }} | ||
| key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-yarn- | ||
|
|
||
| - name: 📦 Install dependencies | ||
| run: yarn install | ||
|
|
||
| - name: 🔄 Verify EAS CLI installation | ||
| run: | | ||
| echo "EAS CLI version:" | ||
| yarn dlx eas-cli@latest --version | ||
|
|
||
| - name: 📋 Fix package.json main entry | ||
| working-directory: ./example | ||
| run: | | ||
| # EAS local builds require `main` to be "node_modules/expo/AppEntry.js". | ||
| # The checked-in value ("index.ts") works for local dev with Metro/Expo Go | ||
| # but causes EAS to fail to resolve the entry point during a local build. | ||
| if [ -f ./package.json ]; then | ||
| # Create a backup | ||
| cp package.json package.json.bak | ||
| # Update the package.json | ||
| jq '.main = "node_modules/expo/AppEntry.js"' package.json > package.json.tmp && mv package.json.tmp package.json | ||
| echo "Updated package.json main entry" | ||
| cat package.json | grep "main" | ||
| else | ||
| echo "package.json not found" | ||
| exit 1 | ||
| fi | ||
|
|
||
| - name: 📱 Build iOS Dev .app | ||
| working-directory: ./example | ||
| run: | | ||
| export NODE_OPTIONS="--openssl-legacy-provider --max_old_space_size=4096" | ||
| yarn dlx eas-cli@latest build --platform ios --profile development --local --non-interactive --output=./app-ios-dev.app | ||
| env: | ||
| NODE_ENV: development | ||
|
|
||
| - name: 📦 Upload build artifact to GitHub | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: app-builds-ios | ||
| path: ./example/app-ios-dev.app | ||
| retention-days: 7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| name: Update iOS SDK | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| version: | ||
| description: 'iOS SDK version (e.g., 3.27.2)' | ||
| required: true | ||
| type: string | ||
| workflow_call: | ||
| inputs: | ||
| version: | ||
| description: 'iOS SDK version (e.g., 3.27.2)' | ||
| required: true | ||
| type: string | ||
|
|
||
| jobs: | ||
| update-ios-sdk: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
|
|
||
| steps: | ||
| - name: Determine version | ||
| id: version | ||
| env: | ||
| INPUT_VERSION: ${{ inputs.version }} | ||
| run: | | ||
| VERSION="${INPUT_VERSION#v}" | ||
| echo "version=$VERSION" >> "$GITHUB_OUTPUT" | ||
| echo "branch=chore/update-ios-sdk-${VERSION}" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - uses: actions/checkout@v4 | ||
| with: | ||
| ref: master | ||
|
|
||
| - name: Update iOS SDK frameworks | ||
| env: | ||
| VERSION: ${{ steps.version.outputs.version }} | ||
| run: ./scripts/update-ios-sdk.sh "$VERSION" | ||
|
|
||
| - name: Check for changes | ||
| id: changes | ||
| run: | | ||
| if git diff --quiet && git diff --cached --quiet; then | ||
| echo "has_changes=false" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "has_changes=true" >> "$GITHUB_OUTPUT" | ||
| fi | ||
|
|
||
| - name: Create Pull Request | ||
| if: steps.changes.outputs.has_changes == 'true' | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| VERSION: ${{ steps.version.outputs.version }} | ||
| BRANCH: ${{ steps.version.outputs.branch }} | ||
| run: | | ||
|
|
||
| git config user.name "github-actions[bot]" | ||
| git config user.email "github-actions[bot]@users.noreply.github.com" | ||
|
|
||
| git checkout -b "$BRANCH" | ||
| git add ios/frameworks/ atomicfi-transact-react-native.podspec | ||
| git commit -m "chore: upgrade iOS SDK to ${VERSION}" | ||
| git push origin "$BRANCH" | ||
|
|
||
| gh pr create \ | ||
| --title "chore: upgrade iOS SDK to ${VERSION}" \ | ||
| --body "Automated upgrade of vendored iOS XCFrameworks to version ${VERSION}. | ||
|
|
||
| **Release notes**: https://github.com/atomicfi/atomic-transact-ios/releases/tag/${VERSION}" \ | ||
| --base master \ | ||
| --head "$BRANCH" \ | ||
| --reviewer atomicfi/sdk | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -86,5 +86,3 @@ android/keystores/debug.keystore | |
| # generated by bob | ||
| lib/ | ||
|
|
||
| # frameworks | ||
| ios/frameworks/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 3.27.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>AvailableLibraries</key> | ||
| <array> | ||
| <dict> | ||
| <key>BinaryPath</key> | ||
| <string>AtomicTransact.framework/AtomicTransact</string> | ||
| <key>LibraryIdentifier</key> | ||
| <string>ios-arm64</string> | ||
| <key>LibraryPath</key> | ||
| <string>AtomicTransact.framework</string> | ||
| <key>SupportedArchitectures</key> | ||
| <array> | ||
| <string>arm64</string> | ||
| </array> | ||
| <key>SupportedPlatform</key> | ||
| <string>ios</string> | ||
| </dict> | ||
| <dict> | ||
| <key>BinaryPath</key> | ||
| <string>AtomicTransact.framework/AtomicTransact</string> | ||
| <key>LibraryIdentifier</key> | ||
| <string>ios-arm64_x86_64-simulator</string> | ||
| <key>LibraryPath</key> | ||
| <string>AtomicTransact.framework</string> | ||
| <key>SupportedArchitectures</key> | ||
| <array> | ||
| <string>arm64</string> | ||
| <string>x86_64</string> | ||
| </array> | ||
| <key>SupportedPlatform</key> | ||
| <string>ios</string> | ||
| <key>SupportedPlatformVariant</key> | ||
| <string>simulator</string> | ||
| </dict> | ||
| </array> | ||
| <key>CFBundlePackageType</key> | ||
| <string>XFWK</string> | ||
| <key>XCFrameworkFormatVersion</key> | ||
| <string>1.0</string> | ||
| </dict> | ||
| </plist> |
Binary file added
BIN
+158 Bytes
ios/frameworks/AtomicTransact.xcframework/_CodeSignature/CodeDirectory
Binary file not shown.
Binary file added
BIN
+180 Bytes
ios/frameworks/AtomicTransact.xcframework/_CodeSignature/CodeRequirements
Binary file not shown.
Binary file added
BIN
+206 Bytes
ios/frameworks/AtomicTransact.xcframework/_CodeSignature/CodeRequirements-1
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.