Skip to content

Add cmake package information#77

Merged
werwurm merged 14 commits intomainfrom
werwurm/cmake_package
Feb 26, 2026
Merged

Add cmake package information#77
werwurm merged 14 commits intomainfrom
werwurm/cmake_package

Conversation

@werwurm
Copy link
Contributor

@werwurm werwurm commented Feb 12, 2026

Add cmake package information generation to make it easier to use for downstream users.

@github-actions
Copy link

github-actions bot commented Feb 12, 2026

LCOV of commit 7a0306f during lcov-test-coverage-report #50

Summary coverage rate:
  lines......: 96.1% (2420 of 2517 lines)
  functions..: 99.5% (194 of 195 functions)
  branches...: 87.3% (1373 of 1573 branches)

Files changed coverage rate: n/a

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds CMake package configuration to enable LibNat20 to be consumed by downstream projects using CMake's find_package() mechanism. The changes implement proper CMake export targets and installation rules for the library.

Changes:

  • Added LibNat20Config.cmake.in template for CMake package configuration
  • Modified target source visibility from INTERFACE to PRIVATE for all library targets
  • Updated include directories to use generator expressions for build/install interface distinction
  • Added install() commands for library targets, headers, and CMake configuration files

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
cmake/LibNat20Config.cmake.in New CMake package configuration template that enables find_package(LibNat20) support
CMakeLists.txt Updated library targets with proper generator expressions, added install rules for targets and headers, and configured CMake package exports
.github/license-check/license-config.json Added cmake.in pattern to license check configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@werwurm werwurm marked this pull request as ready for review February 25, 2026 19:16
@werwurm werwurm requested review from seidelrj and timhirsh February 25, 2026 19:16
Copy link
Contributor

@seidelrj seidelrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a cmake expert, but this looks reasonable.

@werwurm werwurm merged commit 813313a into main Feb 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants