-
Notifications
You must be signed in to change notification settings - Fork 167
feat: Add three new DPoP errors to CredentialsManagerException
#949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pmathew92
wants to merge
11
commits into
main
Choose a base branch
from
dpop_thumbprint_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ec2c6ed
Added two new exceptions to CredentialsManager class (#939)
pmathew92 29c94ab
Store the Dpop thumbprint to local storage (#940)
pmathew92 4477a84
Dpop thumbprint validation (#942)
pmathew92 f54d0d2
Added tests cases for the DPoP validation and save scenarios (#945)
pmathew92 9f24247
doc: Updated the `Examples.md` file with the new CredentialsManagerEx…
pmathew92 870a924
Added two new exceptions to CredentialsManager class (#939)
pmathew92 ffd91da
Store the Dpop thumbprint to local storage (#940)
pmathew92 2aa123c
Dpop thumbprint validation (#942)
pmathew92 1c0b25e
Added tests cases for the DPoP validation and save scenarios (#945)
pmathew92 dc3b459
doc: Updated the `Examples.md` file with the new CredentialsManagerEx…
pmathew92 1e94ef3
Merge branch 'dpop_thumbprint_fix' of https://github.com/auth0/Auth0.…
pmathew92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmathew92 do we need clearCredentials() here or expect the client to clear it on returning DPOP_KEY_MISSING exception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the key is missing and the the token is dpop bound, user has to be re-authenticated . So clearing the stored credentials here to avoid any stale data