Add compliant and noncompliant examples of python/notebook-variable-redefinition@v1.0#80
Open
ankit-amazon wants to merge 5 commits intoaws-samples:mainfrom
Open
Conversation
linghuiluo
reviewed
May 9, 2023
| } | ||
| ], | ||
| "source": [ | ||
| "# Compliant: even though there are 2 different types assigned to variable `z`, it is only used within the same cells.\n", |
There was a problem hiding this comment.
Even though there are 2 different types assigned to variable z in two different cells, it is only used within one of the two cells.
san2488
requested changes
May 15, 2023
Contributor
san2488
left a comment
san2488
left a comment
There was a problem hiding this comment.
DetectorLibrary only supports .py files.
linghuiluo
reviewed
May 19, 2023
| ], | ||
| "source": [ | ||
| "# Noncompliant: variable `z` is assigned to 2 different types of values in above cells 3 and 4. \n", | ||
| "# Then in cell 5, the value of `z` is used in a `print()` call.\n", |
There was a problem hiding this comment.
Then in cell 5, the value of z is used in a print() call, which can have different result depending on the execution order of cells. \n"
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # {fact rule=notebook-variable-redefinition@v1.0 defects=1} | ||
| # —— Code Cell 1, Execution Count 1 —— # |
There was a problem hiding this comment.
In this example, remove all Execution Count, as this information is not needed
Write this.
# —— Code Cell 1—— #
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes: