feat: record command attrs on telemetry failure via fallbackAttrs#1204
Open
Hweinstock wants to merge 1 commit into
Open
feat: record command attrs on telemetry failure via fallbackAttrs#1204Hweinstock wants to merge 1 commit into
Hweinstock wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
agentcore-harness-reviewing
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-1204-tarball/aws-agentcore-0.13.1.tgz |
agentcore-cli-automation
approved these changes
May 11, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
LGTM — clean, focused change that addresses a real gap in failure telemetry.
Verified:
fallbackAttrsdefaults to{}when not provided, preserving existing behavior for callers that haven't been updated.Object.keys(attrs).length > 0guard inrecordCommandRuncorrectly skipsresilientParsefor the empty-attrs case (plain failure/cancel without fallbacks), so the cancel path (recordCommandRun(command, { exit_reason: 'cancel' }, {}, ...)) still behaves as before.- Widening
CreateAttrs.agent_typefromz.enum(['create', 'import'])toAgentType(['create', 'byo', 'import']) is correct —byois a valid TUI agent type (src/cli/tui/screens/agent/types.ts) that was previously being dropped by strict parse. - Moving validation inside the
runCliCommandcallback (so validation failures go through telemetry) while keeping a separate validation for the dry-run branch avoids double-validation. - Tests use real dependencies (
InMemorySink, real temp directories viacreateTelemetryHelper) — no excessive mocking. - Telemetry is instrumented for the new behavior, which is the point of the PR.
Nothing to change.
github-actions
Bot
removed
the
agentcore-harness-reviewing
Hweinstock
force-pushed
the
feat/telemetry-failure-attrs
branch
from
6d8c318 to
4b51a3e
Compare
Hweinstock
force-pushed
the
feat/telemetry-failure-attrs
branch
from
4b51a3e to
7a94482
Compare
Hweinstock
force-pushed
the
feat/telemetry-failure-attrs
branch
from
7a94482 to
b6df589
Compare
Add optional fallbackAttrs parameter to client.withCommandRun so
command-specific attributes are recorded even when the callback throws.
- client.ts: accept fallbackAttrs, use on failure instead of {}
- client.ts: run resilientParse on all non-empty attrs (not just success)
- cli-command-run.ts: withCommandRunTelemetry passes attrs as fallbackAttrs
- cli-command-run.ts: runCliCommand accepts optional knownAttrs param
- command.tsx: extract knownAttrs upfront, pass to runCliCommand
- client.test.ts: add unit tests for fallbackAttrs behavior
- create-edge-cases.test.ts: assert attrs present on failure entry
Hweinstock
force-pushed
the
feat/telemetry-failure-attrs
branch
from
b6df589 to
b26d44c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds optional
fallbackAttrsparameter toclient.withCommandRunso command-specific attributes (language, framework, etc.) are recorded even when the callback throws. Previously failure telemetry only had exit_reason + error_name.Related Issue
N/A
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.