Skip to content

fix(ci): pass codecov token to unit test workflow. #1792

Merged
tejaskash merged 3 commits into
refactorfrom
fix/codecov-secrets
Jul 20, 2026
Merged

fix(ci): pass codecov token to unit test workflow. #1792
tejaskash merged 3 commits into
refactorfrom
fix/codecov-secrets

Conversation

@Hweinstock

@Hweinstock Hweinstock commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Problem

#1775

Summary is that codecov uploads are passing on PRs, but not on push to refactor branch due to missing token error.
Root cause is that we aren't passing the token through the workflow call confirmed by fix testing below.

Solution

  • pass secret to unit test job so that it can upload.
  • also only upload a single report, since AFAICT codecov is discarding them for the same commit anyway.

Testing

@github-actions github-actions Bot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Jul 17, 2026
@codecov-commenter

codecov-commenter commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (refactor@22edb1a). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff             @@
##             refactor    #1792   +/-   ##
===========================================
  Coverage            ?   93.57%           
===========================================
  Files               ?      115           
  Lines               ?     6681           
  Branches            ?        0           
===========================================
  Hits                ?     6252           
  Misses              ?      429           
  Partials            ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hweinstock
Hweinstock force-pushed the fix/codecov-secrets branch from 69ff0d5 to 98f428d Compare July 17, 2026 19:31
@Hweinstock Hweinstock changed the title fix(ci): pass codecov token to unit test workflow to allow push to up… fix(ci): pass codecov token to unit test workflow. Jul 17, 2026
@Hweinstock
Hweinstock marked this pull request as ready for review July 17, 2026 20:03
@tejaskash
tejaskash merged commit d4c31b1 into refactor Jul 20, 2026
4 of 5 checks passed
@tejaskash
tejaskash deleted the fix/codecov-secrets branch July 20, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants