chore: improve chain creation readability and fix must_use_pipeline dead code - #1263
Open
karenc-bq wants to merge 3 commits into
Open
chore: improve chain creation readability and fix must_use_pipeline dead code#1263karenc-bq wants to merge 3 commits into
karenc-bq wants to merge 3 commits into
Conversation
karenc-bq
marked this pull request as ready for review
August 4, 2026 23:34
sophia-bq
approved these changes
Aug 5, 2026
Comment on lines
+989
to
+1001
| """Whether this method has to run through the plugin pipeline. | ||
|
|
||
| Mirrors JDBC ``ConnectionPluginManager.mustUsePipeline``: the pipeline is required when | ||
| the method always uses it, when the chain has not been built yet (nothing to decide on), | ||
| when a real plugin is subscribed, or when telemetry is on (so per-plugin NESTED spans are | ||
| still emitted). | ||
|
|
||
| Intentional deviation from JDBC: the trailing ``is_network_bound_method`` term. JDBC's | ||
| DefaultConnectionPlugin is a thin passthrough, but Python's DefaultPlugin.execute also | ||
| applies DriverDialect.execute's socket timeout and its interrupt-and-wait cleanup. Skipping | ||
| that for a network-bound method lets a later close/reuse race a still-running operation | ||
| (env-4 SIGSEGV), so those methods stay on the pipeline regardless of subscriptions. | ||
| """ |
Contributor
There was a problem hiding this comment.
Curious on whether we want to leave this full description in? Mostly a style choice on whether we want multiple references to JDBC in the actual code or if this would be better served as a PR description?
Contributor
Author
There was a problem hiding this comment.
Good question. Lets keep JDBC references out of the actual code for now. Will remove.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.