chore: update the async initial strategy plugin - #1264
Open
karenc-bq wants to merge 1 commit into
Open
Conversation
sophia-bq
reviewed
Aug 5, 2026
|
|
||
| Setting a value outside the valid set for the given endpoint raises an error. | ||
|
|
||
| > **Note:** `endpoint_substitution_role=any` is accepted only for a custom cluster endpoint, but host selection for the `any` role is not currently supported — it raises an unsupported-strategy error at connect time. Use `reader` or `none` for custom cluster endpoints. |
Contributor
There was a problem hiding this comment.
I find this note to be quite confusing - it doesn't match the table and it seems to me that any is not supported
| InstanceSubstitutionStrategy.SUBSTITUTE_WITH_ANY) | ||
|
|
||
| svc.get_host_info_by_strategy.assert_not_called() | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
I think this needs a second line
| async def _get_verified_reader( | ||
| raise | ||
|
|
||
| return await connect_func() |
Contributor
There was a problem hiding this comment.
Just to double check: if we time out - we default back to connect_func() ? I believe we raise an error in the sync version. You might just want to document this change if it is intended. Some consequences are: if we set verify role it will retry for the whole time and if it can't connect to the right role it will still return a wrong role after trying until timeout
karenc-bq
force-pushed
the
chore/initial-strategy-plugin-async
branch
from
August 6, 2026 01:25
30ea80a to
16070b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the async initial strategy plugin
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.