feat: generate cdk.json JSON Schema from cli-config source of truth#1573
Draft
9pace wants to merge 2 commits into
Draft
feat: generate cdk.json JSON Schema from cli-config source of truth#15739pace wants to merge 2 commits into
9pace wants to merge 2 commits into
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1573 +/- ##
==========================================
- Coverage 88.16% 87.76% -0.41%
==========================================
Files 76 77 +1
Lines 10841 10952 +111
Branches 1494 1510 +16
==========================================
+ Hits 9558 9612 +54
- Misses 1255 1312 +57
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
75841d9 to
7b9a321
Compare
Adds a 4th generation target to user-input-gen that produces a JSON Schema (draft-07) for cdk.json from the same CliConfig source of truth used for yargs, types, and config conversion. - Schema generator covering all global + per-command options - Warn-only validation on config load (never blocks) - $schema pointer in cdk init templates for IDE autocomplete - Schema included in npm package Fixes #743
Contributor
|
Total lines changed 1605 is greater than 1000. Please consider breaking this PR down. |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a generated JSON Schema for `cdk.json` as a 4th output target in `user-input-gen`, alongside the existing yargs, types, and config conversion outputs. Because it's generated from `cli-config.ts`, it can never drift from actual supported options.
What's included:
Design decisions:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license