Skip to content

testing fixes for windows-arm ci#2896

Closed
sgmenda wants to merge 1 commit intoaws:mainfrom
sgmenda:fix-for-windows-ci
Closed

testing fixes for windows-arm ci#2896
sgmenda wants to merge 1 commit intoaws:mainfrom
sgmenda:fix-for-windows-ci

Conversation

@sgmenda
Copy link
Copy Markdown
Contributor

@sgmenda sgmenda commented Dec 10, 2025

This reverts commit 6de0cdb.

The test was not failing before it: https://github.com/aws/aws-lc/actions/runs/19558029015/job/56004861170

And fails after: https://github.com/aws/aws-lc/actions/runs/19583522391/job/56087698449

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@sgmenda sgmenda self-assigned this Dec 10, 2025
@sgmenda sgmenda requested a review from a team as a code owner December 10, 2025 17:56
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.23%. Comparing base (f5e4585) to head (8e57b05).
⚠️ Report is 175 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2896      +/-   ##
==========================================
+ Coverage   78.22%   78.23%   +0.01%     
==========================================
  Files         683      683              
  Lines      117491   117477      -14     
  Branches    16510    16507       -3     
==========================================
+ Hits        91909    91911       +2     
+ Misses      24694    24679      -15     
+ Partials      888      887       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sgmenda
Copy link
Copy Markdown
Contributor Author

sgmenda commented Dec 11, 2025

this did not fix the windows ci, so closing.

@sgmenda sgmenda closed this Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants