Add binary integration testing support to GitHub Actions workflow#8693
Add binary integration testing support to GitHub Actions workflow#8693roger-zhangg merged 24 commits intoaws:developfrom
Conversation
valerena
left a comment
There was a problem hiding this comment.
Just some minor comments, but it looks good
tests/install-sam-cli-binary.sh
Outdated
| # Nightly installs as sam-nightly; rename to sam | ||
| if [ -f /usr/local/bin/sam-nightly ]; then | ||
| sudo mv /usr/local/bin/sam-nightly /usr/local/bin/sam |
There was a problem hiding this comment.
Minor, but you could move this if to outside of the case
There was a problem hiding this comment.
For the first comment, I think it make more sense to actually install sam cli in a venv for normal integ tests. So we get a clearer env and consistency accross the tests. I will make that change
There was a problem hiding this comment.
And yes, the goal is to avoid "making a test wrongly succeed"
There was a problem hiding this comment.
Seems it's not super straightforward to do, the main blocker as "make pr" if we install sam cli in a venv, we need to use that venv to run all the make PR steps and eventually we need to run pytest in the venv as well. It's basically the same as running in system python directly. Unless we create a new workflow "make init-inte-test" but this makes test confusing. Probably better to stick to just make init & install in the system.
|
Updated a minor case: our nightly release will not publish, it keeps editing an old release so need to listen on edit event. |
valerena
left a comment
There was a problem hiding this comment.
The new changes look good!

Changes
workflow_dispatchinputinstall_modewith options:code(default),binary(nightly),latest-releaseMakefiletargets:init-nightly,init-latest-release,setup-pytestscripts/install-sam-cli-binary.shfor cross-platform (Linux/macOS) SAM CLI binary installationgh release downloadinstead of raw curl for GitHub release assetsSAM_CLI_DEVin binary flows so tests usesaminstead ofsamdev/usr/local/bin/zigwrapper for SAM CLI's cargo-lambda Rust buildsTesting
Tested via
workflow_dispatchwithinstall_mode=binaryon thebinary-testbranch.