Skip to content

test(waf): remove flaky WafIntegrationTest for deprecated WAF Classic#7193

Open
jencymaryjoseph wants to merge 1 commit into
masterfrom
flaky-test/waf-integration-stale-change-token
Open

test(waf): remove flaky WafIntegrationTest for deprecated WAF Classic#7193
jencymaryjoseph wants to merge 1 commit into
masterfrom
flaky-test/waf-integration-stale-change-token

Conversation

@jencymaryjoseph

@jencymaryjoseph jencymaryjoseph commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Motivation and Context

WafIntegrationTest failed in preview/release integration builds with:
WafStaleDataException: The input token is no longer current. (HTTP 400) on createIPSet and (during teardown) deleteIPSet.

The root cause is WAF Classic's single-use change-token model combined with the tests running against a shared account: a change token can be consumed by a concurrent change before this test's mutating call uses it.

Modifications

Rather than add retry logic to stabilize the test, we are removing it: services/waf is WAF Classic, which is deprecated — AWS WAF Classic support ended on September 30, 2025.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@jencymaryjoseph
jencymaryjoseph requested a review from a team as a code owner July 24, 2026 18:14
@bhoradc
bhoradc requested review from dagnir and zoewangg and removed request for zoewangg July 24, 2026 18:28
@jencymaryjoseph
jencymaryjoseph force-pushed the flaky-test/waf-integration-stale-change-token branch from 74df3c7 to cee2dd9 Compare July 24, 2026 18:52
@jencymaryjoseph jencymaryjoseph changed the title test(waf): fix flaky WafIntegrationTest by retrying on stale change token test(waf): remove flaky WafIntegrationTest for deprecated WAF Classic Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants