Skip to content

fix(memory-integ): address capacity cap and update failures in tests - #603

Closed
Hweinstock wants to merge 1 commit into
aws:mainfrom
Hweinstock:fix/integ
Closed

fix(memory-integ): address capacity cap and update failures in tests#603
Hweinstock wants to merge 1 commit into
aws:mainfrom
Hweinstock:fix/integ

Conversation

@Hweinstock

@Hweinstock Hweinstock commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Failing integ tests on main: https://github.com/aws/bedrock-agentcore-sdk-python/actions/runs/30303039785/job/90288106089.

Problem

Failing integ tests on main: https://github.com/aws/bedrock-agentcore-sdk-python/actions/runs/30303039785/job/90288106089 with two root causes:

  • add_strategy(wait_for_active=True) only waited for the strategy to reach ACTIVE, but the memory itself could still be in UPDATING state. Consecutive add_strategy calls (as in test_add_strategy_immediately_after_another) would hit ValidationException: Memory is in transitional state UPDATING.
  • CI account hit memory limit with 150.

Solution

After the strategy is confirmed ACTIVE, add_strategy now also checks the memory status and waits for it to return to ACTIVE using the existing _wait_for_memory_active utility.

Testing

  • All 6 integ tests pass against dev account (previously test 4 failed consistently)
  • Logs confirm the fix: strategy goes ACTIVE in 0.2s, then waits ~130s for memory to return to ACTIVE before proceeding

@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Jul 28, 2026
@github-actions github-actions Bot added size/s PR size: S and removed size/s PR size: S labels Jul 28, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@f1a7106). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/bedrock_agentcore/memory/controlplane.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage        ?   89.03%           
=======================================
  Files           ?      103           
  Lines           ?     9134           
  Branches        ?     1381           
=======================================
  Hits            ?     8132           
  Misses          ?      649           
  Partials        ?      353           
Flag Coverage Δ
unittests 89.03% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants