Skip to content

Conversation

@gzmiao8
Copy link
Contributor

@gzmiao8 gzmiao8 commented Dec 3, 2025

Problem

  • Some unreferenced code exist within the transform servers
  • Excessive and redundant debug logging in transform servers and makes it difficult to track actual progress

Solution

  • Removed unreferenced methods and imports in transformConfigurationServer and transformHandler
  • Reduce debug logs while preserving important progress indicators across transformConfigurationServer, transformHandler, and AtxTokenServiceManager.

Testing

  • Tested manually e2e with IDE.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gzmiao8 gzmiao8 requested a review from a team as a code owner December 3, 2025 00:18
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 2.15827% with 136 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.38%. Comparing base (870d540) to head (ef1eb40).

Files with missing lines Patch % Lines
...anguage-server/netTransform/atxTransformHandler.ts 0.00% 119 Missing ⚠️
...ed/amazonQServiceManager/AtxTokenServiceManager.ts 7.69% 12 Missing ⚠️
...rver/configuration/transformConfigurationServer.ts 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2541      +/-   ##
==========================================
+ Coverage   60.17%   60.38%   +0.20%     
==========================================
  Files         277      277              
  Lines       65124    64755     -369     
  Branches     4112     4102      -10     
==========================================
- Hits        39188    39101      -87     
+ Misses      25853    25571     -282     
  Partials       83       83              
Flag Coverage Δ
unittests 60.38% <2.15%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

this.logging.log(`TransformConfigurationServer: Bearer token added to command`)
} catch (error) {
this.logging.error(`TransformConfigurationServer: Failed to add ATX bearer token: ${error}`)
this.logging.error(`TransformConfigurationServer: Failed to add ATX bearer token: ${String(error)}`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arent these equivalent? what the difference

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes they are, just reverted the change.

@gzmiao8 gzmiao8 merged commit 5d0cc7b into main Dec 8, 2025
10 of 11 checks passed
@gzmiao8 gzmiao8 deleted the log-removal branch December 8, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants