Fix incorrect nodeSelector label for deep health check (#382)#386
Open
FarhanTejani wants to merge 1 commit intoaws:mainfrom
Open
Fix incorrect nodeSelector label for deep health check (#382)#386FarhanTejani wants to merge 1 commit intoaws:mainfrom
FarhanTejani wants to merge 1 commit intoaws:mainfrom
Conversation
zhaoqizqwang
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing and why?
Closes #382
The
deep_health_check_passed_nodes_onlyoption generates an incorrect nodeSelector labeldeep-health-check-passed: "true"which doesn't match any actual HyperPod EKS node label, causing jobs to stay Pending indefinitely.Fixed to use the correct label
sagemaker.amazonaws.com/deep-health-check-status: "Passed"in both v1.0 and v1.1 templates and models.Before/After UX
Before:
Jobs submitted with
--deep-health-check-passed-nodes-only truegenerate:Pods stay Pending because no node has this label.
After:
Pods schedule on nodes that passed deep health check.
How was this change tested?
Unit tests pass (1029 existing + 3 new)
Are unit tests added?
Yes
Are integration tests added?
N/A
Reviewer Guidelines
One of the following must be true: