fix: create asymmetric validation key in step compiler#5823
Open
nmadan wants to merge 1 commit intoaws:masterfrom
Open
fix: create asymmetric validation key in step compiler#5823nmadan wants to merge 1 commit intoaws:masterfrom
nmadan wants to merge 1 commit intoaws:masterfrom
Conversation
mollyheamazon
previously approved these changes
May 1, 2026
rohangujarathi
previously approved these changes
May 1, 2026
| @@ -342,7 +342,7 @@ def test_get_function_step_result_wrong_container(mock_session): | |||
| from sagemaker.mlops.workflow.pipeline import get_function_step_result | |||
|
|
|||
Contributor
There was a problem hiding this comment.
This file needs one more test case with a path like s3://bucket/step1/20240101T120000/exec-id/results to prove the new logic handles the new format correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #5787
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.