fix(consensus): reconcile existing safe block before build fallback#3885
Draft
niran wants to merge 1 commit into
Draft
fix(consensus): reconcile existing safe block before build fallback#3885niran wants to merge 1 commit into
niran wants to merge 1 commit into
Conversation
Collaborator
🟡 Heimdall Review Status
|
Comment on lines
+207
to
+209
| Err(_) => { | ||
| warn!(target: "engine", block_num, "Failed to fetch derived L2 block before build fallback"); | ||
| return Err(ConsolidateTaskError::FailedToFetchUnsafeL2Block); |
Contributor
There was a problem hiding this comment.
nit: The error from l2_block_by_label is discarded here. While this follows the pre-existing pattern at line 262, it makes diagnosing RPC failures harder. Consider logging the error:
Suggested change
| Err(_) => { | |
| warn!(target: "engine", block_num, "Failed to fetch derived L2 block before build fallback"); | |
| return Err(ConsolidateTaskError::FailedToFetchUnsafeL2Block); | |
| Err(e) => { | |
| warn!(target: "engine", block_num, error = ?e, "Failed to fetch derived L2 block before build fallback"); | |
| return Err(ConsolidateTaskError::FailedToFetchUnsafeL2Block); | |
| } |
Contributor
✅ base-std fork tests: all 616 passedbase/base is fully in sync with the base-std spec.
|
Contributor
Review SummaryOverall this is a well-structured fix for a real edge case where an earlier unsafe FCU returns What the PR does right
Minor finding
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SYNCING, EL later backfilled the block, and safe derivation resumes while consensus unsafe is still pinnedTesting
cargo +nightly fmtgit diff --checkcargo test -p base-consensus-engineChange Management
type=routine
risk=low
impact=sev5