You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What changed? Why?
Before the change, the line was run yarn add -D @playwright/test @coinbase/onchaintestkit. When I copied it and ran it in the terminal, it gave an error. So, for clarity:
I separated “Run:” and the command
I wrapped the command in a syntax-highlighted code block (```bash)
Now the copy button copies the working command.
Notes to reviewers
How has it been tested?
Copied the command, it works in the terminal.
Nice documentation improvement! Separating the command from the description and using proper bash code blocks makes it much easier to copy-paste.
The copy button functionality is especially helpful for onboarding new contributors to the E2E testing workflow.
Nice documentation improvement! Separating the command from the description and using proper bash code blocks makes it much easier to copy-paste. The copy button functionality is especially helpful for onboarding new contributors to the E2E testing workflow.
Thank you very much for your kind words! To be honest, I would like to improve the Base documentation even more, but it is already very professional and beautifully designed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Before the change, the line was
run yarn add -D @playwright/test @coinbase/onchaintestkit. When I copied it and ran it in the terminal, it gave an error. So, for clarity:Now the copy button copies the working command.
Notes to reviewers
How has it been tested?
Copied the command, it works in the terminal.
Have you tested the following pages?
BaseWeb