Skip to content

Fix numerics in xcconfig #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acidlynx wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix numerics in xcconfig #57

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a71a202
Fix in case when xcconfig have numbers
acidlynx Jan 14, 2022
fb0d752
Merge pull request #1 from acidlynx/fix/work_with_numeric_in_xcconfig
acidlynx Jan 14, 2022
4559526
Fix codestyle
acidlynx Jan 26, 2022
34f2b91
Exclude private headers in public headers section
Feb 3, 2022
0fbdab6
Merge pull request #2 from acidlynx/fix/exclude_private_headers_from_…
acidlynx Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/cocoapods/bazel/xcconfig_resolver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ module XCConfigResolver
def resolved_build_setting_value(setting, settings:)
return unless (value = settings[setting])

sub_prefix = ->(s) { s.sub(%r{\A:/}, '') }
sub_prefix = ->(s) {
str_value = s.to_s
str_value.sub(%r{\A:/}, '')
return str_value
}
Copy link
Contributor

@thiagohmcruz thiagohmcruz Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep this in one line sub_prefix = ->(s) { s.to_s.sub(%r{\A:/}, '') }? I would split this into more lines only if you had the intent of further manipulating the intermediary values

Copy link
Author

@acidlynx acidlynx Jan 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks!

resolved = resolve_string_with_build_settings(value, settings: settings)
if Pod::Target::BuildSettings::PLURAL_SETTINGS.include?(setting)
resolved.shellsplit.reject(&:empty?).map(&sub_prefix)
Expand Down