Fix https://github.com/bazelbuild/rules_rust/issues/2231

[tshepherd-zoox]

The issue in #2231 is that we add too many attrs to the reproducible set:

    attrs = {attr: getattr(repository_ctx.attr, attr) for attr in dir(repository_ctx.attr)}
    exclude = ["to_json", "to_proto"]
    for attr in exclude:
        attrs.pop(attr, None)

This PR instead moves the crates_repository attrs to a variable so that we can only include these in the reproducible set, silencing the debug logging during loading.

Lmk if you have any questions. CLA should be covered by company CLA between Zoox and Google, I was told.

[tshepherd-zoox]

To elaborate, we saw the following message in our bazel repo:

    (08:02:24) DEBUG: Rule 'crates' indicated that a canonical reproducible form can be obtained by modifying arguments _action_listener = <unknown object
    com.google.devtools.build.lib.packages.Attribute$LabelListLateBoundDefault>, _config_dependencies = [], _configure = False, _environ =
    ["CARGO_BAZEL_GENERATOR_URL", "CARGO_BAZEL_GENERATOR_SHA256", "CARGO_BAZEL_REPIN", "REPIN", "CARGO_BAZEL_REPIN_ONLY", "CARGO_BAZEL_ISOLATED",
    "CARGO_BAZEL_DEBUG", "CARGO_BAZEL_TIMEOUT"], _original_name = ""
    (08:02:24) DEBUG: Repository crates instantiated at:
      <redacted>/WORKSPACE:288:20: in <toplevel>
      <redacted>/rust_crates/crates_repositories.bzl:4:22: in crates_repositories
    Repository rule crates_repository defined at:
      <redacted>/.cache/bazel/<redacted>/rules_rust/crate_universe/private/crates_repository.bzl:157:36:
    in <toplevel>

This patch fixes the logging in our internal builds.

I believe this is the issue in #2231 as well.

[illicitonion]

Can I check - which attrs are you intentionally ignoring that were previously being included before this change?

[tshepherd-zoox]

Things like _action_listener, to_json, to_proto, etc. that are contributed by dir(repository_ctx.attr), which also includes methods. The existing code manually excluded those first two specific methods, presumably due to not being serializable (?)

The solution I'm proposing is to opt- in to only the attributes used in the crates_repository repository_rule, not dir(repository_ctx.attr)

[tshepherd-zoox]

Hi @illicitonion , any update on this?

[UebelAndre]

Ah, sorry I didn't see this. I implemented #3904 to solve the same issue. I'm gonna close this out but if there's another issue with the change that was merged I'd be happy to review another fix!