Skip to content

Add accordion component#140

Merged
clarasb merged 4 commits intomainfrom
clarasb-134-add_accordion_component
Mar 9, 2026
Merged

Add accordion component#140
clarasb merged 4 commits intomainfrom
clarasb-134-add_accordion_component

Conversation

@clarasb
Copy link
Collaborator

@clarasb clarasb commented Feb 25, 2026

This PR:

  • adds a Accodion component to the mui plugin.
  • adds a demo panel to showcase the component.

Notes:

  • AccordionActions is not supported yet.
  • The current implementation focuses on summary and details of Accordion only.

Mentioned in Widget Wishlist (#41).
Closes #134.


Demo Panel I:
image

@clarasb clarasb marked this pull request as ready for review February 25, 2026 09:39
@clarasb clarasb requested review from b-yogesh and forman February 25, 2026 09:39
Copy link
Collaborator

@b-yogesh b-yogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Please have a look at my comments.

icon="arrow_drop_down",
# expanded=True,
# disabled=True
children=[table],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we can have multiple children for this component? How does that look like?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the Accordion component accepts multiple children, which are rendered in the order they are provided. Additional styling can be applied via the style prop.

@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.27%. Comparing base (794871e) to head (975bfc2).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...lets.js/packages/lib/src/plugins/mui/Accordion.tsx 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   92.22%   92.27%   +0.05%     
==========================================
  Files          87       89       +2     
  Lines        1504     1528      +24     
  Branches      231      236       +5     
==========================================
+ Hits         1387     1410      +23     
- Misses         98       99       +1     
  Partials       19       19              
Flag Coverage Δ
backend 100.00% <100.00%> (ø)
frontend 83.98% <88.88%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@b-yogesh
Copy link
Collaborator

b-yogesh commented Mar 9, 2026

Thank you for applying the change requests. Can you just attach the screenshot of the updated demo with multiple children? Feel free to merge after that.

@clarasb clarasb merged commit e295ef8 into main Mar 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add accordion component

3 participants