Update react-vega to v8 and adapt VegaChart accordingly#141
Open
Update react-vega to v8 and adapt VegaChart accordingly#141
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 92.22% 92.85% +0.63%
==========================================
Files 87 87
Lines 1504 1525 +21
Branches 231 232 +1
==========================================
+ Hits 1387 1416 +29
+ Misses 98 91 -7
+ Partials 19 18 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b-yogesh
approved these changes
Mar 6, 2026
Collaborator
b-yogesh
left a comment
b-yogesh
left a comment
There was a problem hiding this comment.
Thanks Clara, it LGTM! Did you also test this out in a fresh node environment and the demos work as expected?
forman
requested changes
Mar 9, 2026
| // Keep cleanup in a ref so it can run on re-embed and unmount. | ||
| const cleanupRef = useRef<null | (() => void)>(null); | ||
|
|
||
| const onEmbed = useCallback( |
Member
There was a problem hiding this comment.
Move into hook in a separate module because it is too much logic here.
| - python >=3.10,<3.14 | ||
| # Optional Dependencies | ||
| - altair>=5.5.0,<6.0.0 | ||
| - altair |
Member
There was a problem hiding this comment.
Since this is a lib dependency, you must limit its range.
| [project.optional-dependencies] | ||
| opt = [ | ||
| "altair>=5.5.0,<6.0.0", | ||
| "altair", |
| ] | ||
| demo = [ | ||
| "altair>=5.5.0,<6.0.0", | ||
| "altair", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
altairpinning. This is not necessary anymoreCloses #132.