Open
Conversation
Member
|
Nice job, thank you! |
owenvoke
reviewed
Feb 14, 2020
| "php": "^7.2", | ||
| "illuminate/support": "5.6.*|5.7.*|5.8.*|^6.0" | ||
| "illuminate/support": "5.6.*|5.7.*|5.8.*|^6.0", | ||
| "symfony/process": "^5.0" |
There was a problem hiding this comment.
Should this be "symfony/process": "^4.0|^5.0"?
| if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') { | ||
| $logPath = base_path() . '\\storage\\logs\\tinkerwell-' . date("Y-m-d") . '.log'; | ||
|
|
||
| // For Windows || ATTENTION ... I added a ^ before the & to escape it. |
There was a problem hiding this comment.
Nice comment! This is an annoying quirk of Windows that I only discovered the other day. 👍
Co-Authored-By: Owen Voke <owzie123@gmail.com>
Member
|
Hey, sorry that this hasn't been merged so far. Could you please update the PR so that it solves the merge conflicts and works with Laravel 7 too? We will take care about this after this has been solved. |
Author
|
Unfortunately, I cannot make it to work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could make it work, that the app is opened in Windows.
The only thing that doesn't work, for now, is that the variables are not populated.
I hope my pull request helps to bring this feature as fast as possible to Windows... because it's awesome!!!