cleanup htmx attributes for reinit during morph#3834
Open
MichaelWest22 wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
Now also handle hx-live cleanup properly so it responds to the cleanup events when morph detects hx-attributes changing and re-inits all hx attributes. This prevents duplicat live functions being registered on morph etc. Also brought in additional tests from @scriptogre branch and my other PR changes to block hx-on from duplicating listeners on re process. Note also had to extend the hx attribute lookup in morph to check :* attributes for changes as well |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Handle morph changing or removing hx- attributes so that it can cleanup and reinitialize them clean. outerSync was already doing this but just moving this logic inside copyAttributes means we now cover morph as well
Corresponding issue:
Testing
Already tests for this in outerSync swap tests but added tests to morph as well
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded