This repository was archived by the owner on Jun 5, 2023. It is now read-only.
a couple of Ruby-compatibility fixes#146
Open
caboteria wants to merge 2 commits intobinarymatt:masterfrom
Open
a couple of Ruby-compatibility fixes#146caboteria wants to merge 2 commits intobinarymatt:masterfrom
caboteria wants to merge 2 commits intobinarymatt:masterfrom
Conversation
added 2 commits
July 1, 2015 18:22
Ruby uses "::" to separate modules from classes, while python uses "." so we'll sniff the queued class name for "::" and if it's there then we're probably handling a job that was queued by Ruby.
Resque expects that the run_at value will be an ISO8601 string in UTC. Pyres was writing seconds since the epoch, which caused resque-web to crash.
caboteria
force-pushed
the
ruby_module
branch
from
cdc0a4f to
65c3e34
Compare
caboteria
changed the title
Contributor
Author
|
Hi, I added a second commit to this branch a few days ago. It makes pyres compatible with the resque-web UI. Previously it wrote the run_at timestamp in a format that made resque-web crash but 65c3e34 changes the format so it's similar to the Ruby resque format and now the UI works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are a couple of fixes that we've used to be able to use Ruby to queue jobs and Python to run them. It's a great combo for us because the web guys like Ruby and the scientists like Python.
First fix: Ruby uses "::" to separate modules from classes, while python uses "."
so we'll sniff the queued class name for "::" and if it's there then
we're probably handling a job that was queued by Ruby.
Second fix: resque-web was crashing because pyres wrote the "run_at" field in a different format than resque. This fix makes pyres use the same format as resque so now resque-web can show pyres jobs.
Thanks!