Move CI and local testing to cargo-rbmt#39
Open
luisschwab wants to merge 6 commits intobitcoindevkit:masterfrom
Open
Move CI and local testing to cargo-rbmt#39luisschwab wants to merge 6 commits intobitcoindevkit:masterfrom
cargo-rbmt#39luisschwab wants to merge 6 commits intobitcoindevkit:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
luisschwab
force-pushed
the
feat/cargo-rbmt
branch
from
f3dceb6 to
5a42baf
Compare
Introduce `cargo-rbmt` for all things cargo, such as linting, formatting and testing. The `rbmt-version` file defines what version is used. The `Cargo.toml` manifest is updated with `cargo-rbmt` specific fields, defining: - Stable and MSRV toolchains - Necessary pins for MSRV (all of them due to `corepc`, once they use `cargo-rbmt` there these can be removed). Fix incorrect MSRV on `Cargo.toml`: from 1.75.0 to 1.85.0 Update the `justfile` to use `cargo-rbmt` for recipes, and updates CI jobs to use the recipes defined in the `justfile` (which use `cargo-rbmt` under the hood). This simplifies configuration by centralizing it in the `justfile`. Update `.gitignore` to exclude `Cargo.lock`. Add a `sigs.yml` CI job that asserts all commits in the branch are signed (no-op on `master`). This job runs `just check-sigs` under the hood.
Run `just pre-push`, which: - Generates `Cargo-minimal.lock` and `Cargo-recent.lock` - Formats code Also renames `tests/test_rpc_client.rs` to `tests/rpc_client.rs`.
luisschwab
force-pushed
the
feat/cargo-rbmt
branch
from
5a42baf to
b8aef56
Compare
Member
Author
|
@ValuedMammal you need to change the required jobs in settings to match these. |
luisschwab
force-pushed
the
feat/cargo-rbmt
branch
from
b8aef56 to
842ef84
Compare
3 tasks
ValuedMammal
reviewed
Apr 5, 2026
Collaborator
ValuedMammal
left a comment
ValuedMammal
left a comment
There was a problem hiding this comment.
I've only partially reviewed the changes but here are some thoughts.
Comment on lines
+18
to
+22
| - name: Setup just | ||
| uses: extractions/setup-just@f8a3cce218d9f83db3a2ecd90e41ac3de6cdfd9b # v3 | ||
|
|
||
| - name: Check commit signatures | ||
| run: just check-sigs |
Collaborator
There was a problem hiding this comment.
nit: I would rather avoid the setup-just dependency for github workflows and just execute a bash script here.
Member
Author
There was a problem hiding this comment.
The idea is to centralize all config in the justfile, and adding a bash script goes against this idea. Let me know what you think. The just CI dep is acceptable IMO.
Member
Author
|
Pushed b53d170 addressing all of @ValuedMammal's reviews, except the one about CI signature checks. |
tvpeter
reviewed
Apr 7, 2026
Updates the README with pointers to `cargo-rbmt` and new recipes. Also adds badges and fixes a bunch of nits.
Also: - Cache build artifacts on CI - Remove unused `jsonrpc` features - Move `corepc-node`-related pins under `dev-dependencies` - Remove `+nightly` from `lock` recipe
luisschwab
force-pushed
the
feat/cargo-rbmt
branch
from
b72ae8c to
0616786
Compare
tvpeter
reviewed
Apr 7, 2026
tvpeter
approved these changes
Apr 7, 2026
Collaborator
tvpeter
left a comment
tvpeter
left a comment
There was a problem hiding this comment.
Well done @luisschwab
You already addressed the comments before I could submit the review.
I left one additional nit.
tACK 0616786
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23
Closes #30
Closes #38
Overrides #25
Overrides #34
Overrides #35
This PR moves CI and local testing to
cargo-rbmt.Changelog