Add CODEOWNERS with primary and secondary maintainers#2127
Add CODEOWNERS with primary and secondary maintainers#2127notmandatory merged 1 commit intobitcoindevkit:masterfrom
Conversation
|
GitHub is saying the codeowners file contains errors, may need discussion. |
|
I think it'd be nice if someone volunteered to maintain the |
Where do you see the GitHub errors? |
91d1294 to
184ee2c
Compare
|
I added / to end of sub-crate paths, I think that's probably what Github was complaining about, but would still like to know where to find the error so I can be sure I got everything right. |
I didn't see any errors as well. |
|
On another note, maybe it's best to explicitly list all crates with their respective maintainers instead of relying on the wildcard (e.g. |
184ee2c to
d4d3528
Compare
Good point, I've added all the crates explicitly now. Also added one I missed, |
d4d3528 to
7eb75c7
Compare
|
I think I also found the error mammal mentioned. It's on the diff and reminded me to give all named maintainers at least write permission. |
I agree with the path proposed by #1973. I can take care of |
|
I agree with nymius, the examples can eventually be converted to well written READMEs in their respective crates. |
|
Yes it was only the write permissions error. |
Description
Add CODEOWNERS file with both primary and secondary maintainers for repo files with overrides for specific sub-crates. See: https://github.com/bitcoindevkit#stable
fixes #1926
Notes to the reviewers
This will trigger a review request for above maintainers for any file changes in the repo.
see: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
Changelog notice
none
Checklists
All Submissions: