Skip to content

Add CODEOWNERS with primary and secondary maintainers#2127

Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom
notmandatory:chore/codeowners
Feb 19, 2026
Merged

Add CODEOWNERS with primary and secondary maintainers#2127
notmandatory merged 1 commit intobitcoindevkit:masterfrom
notmandatory:chore/codeowners

Conversation

@notmandatory
Copy link
Member

@notmandatory notmandatory commented Feb 17, 2026

Description

Add CODEOWNERS file with both primary and secondary maintainers for repo files with overrides for specific sub-crates. See: https://github.com/bitcoindevkit#stable

fixes #1926

Notes to the reviewers

This will trigger a review request for above maintainers for any file changes in the repo.

see: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

Changelog notice

none

Checklists

All Submissions:

luisschwab

This comment was marked as outdated.

@ValuedMammal
Copy link
Collaborator

GitHub is saying the codeowners file contains errors, may need discussion.

@ValuedMammal
Copy link
Collaborator

I think it'd be nice if someone volunteered to maintain the examples/ directory or else find a way to greatly simplify it #1973.

@notmandatory
Copy link
Member Author

GitHub is saying the codeowners file contains errors, may need discussion.

Where do you see the GitHub errors?

@notmandatory
Copy link
Member Author

I added / to end of sub-crate paths, I think that's probably what Github was complaining about, but would still like to know where to find the error so I can be sure I got everything right.

@luisschwab
Copy link
Member

Where do you see the GitHub errors?

I didn't see any errors as well.

@luisschwab
Copy link
Member

On another note, maybe it's best to explicitly list all crates with their respective maintainers instead of relying on the wildcard (e.g. bdk_electrum's maintainers should list leonardo and evan, even though they're on the wildcard expression).

@notmandatory
Copy link
Member Author

notmandatory commented Feb 19, 2026

On another note, maybe it's best to explicitly list all crates with their respective maintainers instead of relying on the wildcard (e.g. bdk_electrum's maintainers should list leonardo and evan, even though they're on the wildcard expression).

Good point, I've added all the crates explicitly now. Also added one I missed, /crates/file_store/ with @nymius .

@notmandatory
Copy link
Member Author

notmandatory commented Feb 19, 2026

I think I also found the error mammal mentioned. It's on the diff and reminded me to give all named maintainers at least write permission.

https://github.com/bitcoindevkit/bdk/compare/d4d352891d61e383fa839c9f2a128ac05967f312..7eb75c7813bf44b0078f01a5674899273d86cc5d

@nymius
Copy link
Contributor

nymius commented Feb 19, 2026

I think it'd be nice if someone volunteered to maintain the examples/ directory or else find a way to greatly simplify it #1973.

I agree with the path proposed by #1973. I can take care of examples/ in the meanwhile, but I would remove it once we know for sure examples/ is a subset of bdk-cli functionality.

@luisschwab
Copy link
Member

I agree with nymius, the examples can eventually be converted to well written READMEs in their respective crates.

@ValuedMammal
Copy link
Collaborator

Yes it was only the write permissions error.

Copy link
Member

@luisschwab luisschwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7eb75c7

Copy link
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7eb75c7

@notmandatory notmandatory merged commit abe121d into bitcoindevkit:master Feb 19, 2026
17 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Chain Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Non-coding related work

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add CODEOWNERS file

6 participants

Comments