Skip to content

Conversation

@MicahMaphet
Copy link
Contributor

@MicahMaphet MicahMaphet commented Dec 13, 2025

  1. Previously when no ETH config was provided it would prevent the other remaining tests from running. I want this to be added so I can test coverage without needing to comment out the ETH and MATIC p2p files. This PR fixes this by skipping Ethereum and Matic p2p when they are not in the config.
  2. Removed /index.js from helpers path as it breaks when I use tsx or ts-node which I plan to use for test coverage.
  3. Renamed test/unit/modules/base/csp.spc.ts -> test/unit/modules/base/csp.spec.ts.

Copy link
Collaborator

@kajoseph kajoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@kajoseph kajoseph merged commit 92b6af7 into bitpay:master Dec 17, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants