[BWS, BWC] TSS - add copayerReady event#4132
Open
gabrielbazan7 wants to merge 1 commit intobitpay:masterfrom
Open
[BWS, BWC] TSS - add copayerReady event#4132gabrielbazan7 wants to merge 1 commit intobitpay:masterfrom
gabrielbazan7 wants to merge 1 commit intobitpay:masterfrom
Conversation
kajoseph
reviewed
Mar 27, 2026
| const p = session.participants.find(p => p.partyId === m.fromPartyId); | ||
| return p?.copayerId; | ||
| }).filter(Boolean) as string[]; | ||
| return { messages, signature: session.signature, participants }; |
Collaborator
There was a problem hiding this comment.
Are you wanting the participants to be returned to the client in real time? Currently, this logic is only hit once all participants have joined (per line 300: if (otherPartyMsgs.length === session.m - 1)). If you want it to be real time, we should move this new logic to be between lines 299-300 and then return participants in the returned object on line 311 (after the if block) as well.
Collaborator
There was a problem hiding this comment.
If we change it as noted above, then the client will just need to be aware that the copayerReady event will fire duplicates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a copayerReady event to TssSign (BWC) so callers can track which copayers have joined a signing session in real time.
Changelog
Testing Notes
Add any helpful notes for reviewers to test your code here.
Checklist