Authentication improvements #21194
Merged
Authentication improvements #21194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need to track the datetime that passwords were changed for the jwt
- use os.open to create jwt secret with restrictive permissions (0o600: read/write for owner only) - add backend validation for password strength - add iat claim to jwt so the server can determine when a token was issued and reject any jwts issued before a user's password_changed_at timestamp, ensuring old tokens are invalidated after a password change - set logout route to public to avoid 401 when logging out - issue new jwt for users who change their own password so they stay logged in
- add field to verify old password - add password strength requirements
avoid /login side effects (creating a new session)
✅ Deploy Preview for frigate-docs canceled.
|
NickM-27
approved these changes
Dec 8, 2025
Just send old_password + new password in one request, let the backend handle verification in a single operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR improves Frigate authentication in a few ways:
password_changed_atto user tableiatto JWTs, enforce token invalidation whentoken.iat < user.password_changed_at, require current password for self-changes, return a fresh JWT after a user changes their own passwordType of change
Additional information
Checklist
enlocale.ruff format frigate)